Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mui-material][Select] Omit placeholder from props #44502

Merged
merged 2 commits into from
Nov 25, 2024

Conversation

Juneezee
Copy link
Contributor

Fixes #43571.

As described in the issue, the placeholder prop of the <Select> component has no effect. To avoid future confusion, such as this StackOverflow post, the placeholder prop should be omitted from the <Select> component.

This commit fixes #43571.

Signed-off-by: Eng Zer Jun <[email protected]>
@aarongarciah aarongarciah added component: select This is the name of the generic UI component, not the React module! package: material-ui Specific to @mui/material labels Nov 25, 2024
@aarongarciah aarongarciah self-requested a review November 25, 2024 10:01
@mui-bot
Copy link

mui-bot commented Nov 25, 2024

Netlify deploy preview

https://deploy-preview-44502--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 9320bc2

Copy link
Member

@aarongarciah aarongarciah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@aarongarciah aarongarciah merged commit 8ac260c into mui:master Nov 25, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: select This is the name of the generic UI component, not the React module! package: material-ui Specific to @mui/material typescript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[material-ui][Select] Select has an unexisting "placeholder" props
3 participants