[pickers] Use the new ownerState in PickersCalendarHeader, PickersArrowSwitcher and DayCalendarSkeleton
#15499
+98
−86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flaviendelangle
added
breaking change
component: pickers
|
Deploy preview: https://deploy-preview-15499--material-ui-x.netlify.app/ |
…owSwitcher and DayCalendarSkeleton
flaviendelangle
force-pushed
the
ownerState-various
branch
from
fd4865a
to
5c9341e
Compare
66 tasks
flaviendelangle
commented
Nov 20, 2024
| <DayCalendarSkeletonDay | ||
| key={index2} | ||
| variant="circular" | ||
| width={DAY_SIZE} | ||
| height={DAY_SIZE} | ||
| className={classes.daySkeleton} | ||
| ownerState={{ day }} | ||
| data-day-in-month={dayInMonth} |
There was a problem hiding this comment.
I can create a DayCalendarSkeletonOwnerState but the component is probably not used a lot and even less overriden with styleOverrides so I went with simplicity here
|
|
||
| export type SlideDirection = 'right' | 'left'; | ||
|
|
||
| interface PickerSlideTransitionOwnerState extends PickerOwnerState { |
There was a problem hiding this comment.
It is not used in any styleOverrides, only in useUtilityClasses but I'm also unifying the parameters of this hook
flaviendelangle
commented
Nov 20, 2024
| expectedClassName: pickersArrowSwitcherClasses.rightArrowIcon, | ||
| }, | ||
| }, | ||
| // TODO: Uncomment once `describeConformance` does not enforce the presence of `ownerState.className` |
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #14475