Remove register #25
Open
Remove register #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Officially deprecated since c++11, but became useless long ago.
Unclear why nobody has noticed for a decade that this code was just totally uncompilable. `SparseMatrix` does not have methods `Columns()` or `Rows()`, and `m_ppElements[i]` is a pointer so can't possibly have anything called with `.`.
Only for Boost >= 1.70.
…ompatible with C++17 [-Wdeprecated-register]
cielavenir
requested review from
rschlaikjer,
lazydroid,
yoshikikanemoto and
jerasman
|
please check PointCloudLibrary#6113 |
|
Pipeline #996359 |
lazydroid
approved these changes
Nov 18, 2024
cielavenir
force-pushed
the
removeRegister
branch
from
ee0f1cf
to
a262c64
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
register raises error on C++17
just in case, I just cherry-picked some upstream commits.