Fix device name not appearing in device logout screen #5251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rablador
force-pushed
the
device-name-does-not-appear-in-bold-in-handledevicedeletion-ios-333
branch
from
71b2483 to
7cd9ed7
Compare
buggmagnet
requested changes
Oct 9, 2023
There was a problem hiding this comment.
According to our design docs, the first button should be the "Yes, log out device" and the second one should be "Back"
This is also what the desktop client displays. Can we fix it in this PR ?
Reviewed 5 of 7 files at r1, all commit messages.
Reviewable status: 5 of 7 files reviewed, all discussions resolved
rablador
force-pushed
the
device-name-does-not-appear-in-bold-in-handledevicedeletion-ios-333
branch
from
7cd9ed7 to
5689dbc
Compare
rablador
commented
Oct 10, 2023
There was a problem hiding this comment.
Done
Reviewable status: 5 of 7 files reviewed, all discussions resolved
buggmagnet
approved these changes
Oct 10, 2023
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: 6 of 7 files reviewed, all discussions resolved
buggmagnet
force-pushed
the
device-name-does-not-appear-in-bold-in-handledevicedeletion-ios-333
branch
from
5689dbc to
f6e3aed
Compare
buggmagnet
deleted the
device-name-does-not-appear-in-bold-in-handledevicedeletion-ios-333
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes device name not appearing in device logout screen. Also, adds icon to device info modal in account screen.
This change is