Make alert view scrollable #5354
Conversation
IOS-359 Make change log scrollable
Currently the change log dialog is not scrollable on iOS, so if there are a lot of changes then the user cannot see them. |
There was a problem hiding this comment.
Would you mind posting a screenshot/screenrecording for this UI change? 🙂
Reviewable status: 0 of 2 files reviewed, all discussions resolved
There was a problem hiding this comment.
Sure thing, will post one soon. 👍
Reviewable status: 0 of 2 files reviewed, all discussions resolved
There was a problem hiding this comment.
Shows three different sizes, where the last scrolls.
Reviewable status: 0 of 2 files reviewed, all discussions resolved
rablador
force-pushed
the
make-change-log-scrollable-ios-359
branch
from
564e0f0 to
15ab0fa
Compare
| buttonView.directionalLayoutMargins.top = UIMetrics.CustomAlert.interContainerSpacing | ||
|
|
||
| // Buttons below scrollable content should have more margin. | ||
| if scrollView.contentSize.height > scrollView.bounds.size.height { |
There was a problem hiding this comment.
| if scrollView.contentSize.height > scrollView.bounds.size.height { | |
| if scrollView.contentSize.height > scrollView.bounds.size.height { |
There was a problem hiding this comment.
Reviewed 1 of 2 files at r1, all commit messages.
Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion (waiting on @rablador)
ios/MullvadVPN/View controllers/Alert/AlertViewController.swift line 195 at r2 (raw file):
Previously, MrChocolatine wrote…
if scrollView.contentSize.height > scrollView.bounds.size.height {
I was wondering what was the difference, it turns out there's an extra space at the end of the if statement.
Thankfully, @rablador did run swiftformat right, right ? ಠ_ಠ
There was a problem hiding this comment.
Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion (waiting on @rablador)
rablador
force-pushed
the
make-change-log-scrollable-ios-359
branch
from
15ab0fa to
c8e18db
Compare
There was a problem hiding this comment.
Reviewable status: 1 of 2 files reviewed, 2 unresolved discussions (waiting on @MrChocolatine)
a discussion (no related file):
Refactored away the setup method and improved encapsulation.
ios/MullvadVPN/View controllers/Alert/AlertViewController.swift line 195 at r2 (raw file):
Previously, buggmagnet wrote…
I was wondering what was the difference, it turns out there's an extra space at the end of the
ifstatement.Thankfully, @rablador did run
swiftformatright, right ? ಠ_ಠ
Err, sure he did. Never missed it once!
rablador
force-pushed
the
make-change-log-scrollable-ios-359
branch
from
c8e18db to
27fe58d
Compare
There was a problem hiding this comment.
Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @MrChocolatine)
buggmagnet
force-pushed
the
make-change-log-scrollable-ios-359
branch
from
27fe58d to
3001603
Compare
buggmagnet
force-pushed
the
make-change-log-scrollable-ios-359
branch
from
3001603 to
ed4d997
Compare
Alert views should be scrollable, which is especially important for the change log.
This change is