Fix expired account UI showing blocked state instead of out of time view #5403
Conversation
IOS-374 Expired account should always show "out of time" view
When an account expires the app sometimes go into blocked state (with banner) instead of routing to the "out of time" view. This typically happens when the tunnel is connected, but not when eg. entering app without time left on the account. |
There was a problem hiding this comment.
Not really sure about this implementation. Please approach it as such and provide feedback for other options (if any).
Untitled.mov
Reviewable status: 0 of 3 files reviewed, all discussions resolved
There was a problem hiding this comment.
The fix looks good but why is it showing the "network issues" banner ?
That's probably another unrelated issue to that though.
Reviewed all commit messages.
Reviewable status: 0 of 3 files reviewed, all discussions resolved
There was a problem hiding this comment.
When you disconnect from blocked state you'll end up in .waitingForConnection for a short while. That's why the banner shows up. Unrelated, but perhaps of import.
Reviewable status: 0 of 3 files reviewed, all discussions resolved
There was a problem hiding this comment.
Ok, I created a Linear issue to keep track of that. Good job !
Reviewable status: 0 of 3 files reviewed, all discussions resolved
buggmagnet
force-pushed
the
expired-account-should-always-show-out-of-time-view-ios-374
branch
from
9d4b688 to
015f7bf
Compare
buggmagnet
deleted the
expired-account-should-always-show-out-of-time-view-ios-374
branch
When an account expires the app sometimes go into blocked state (with banner) instead of routing to the "out of time" view. This typically happens when the tunnel is connected, but not when eg. entering app without time left on the account.
This change is