Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove TestActivity and related files since it is not needed #5663

Merged
merged 1 commit into from
Jan 12, 2024

Conversation

Pururun
Copy link
Contributor

@Pururun Pururun commented Jan 8, 2024

The manifest file was causing some errors about security vulnerabilities so we will remove everything related since it seems that it was not needed.


This change is Reviewable

@Pururun Pururun added the Android Issues related to Android label Jan 8, 2024
@Pururun Pururun requested a review from albin-mullvad January 8, 2024 11:57
@Pururun Pururun self-assigned this Jan 8, 2024
Copy link

linear bot commented Jan 8, 2024

@Pururun Pururun force-pushed the remove-testactivity-droid-632 branch 3 times, most recently from 76cf78e to 03b391f Compare January 10, 2024 13:56
Copy link
Collaborator

@albin-mullvad albin-mullvad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 3 files at r1, all commit messages.
Reviewable status: 2 of 3 files reviewed, 1 unresolved discussion (waiting on @Pururun)


android/app/src/debug/AndroidManifest.xml line 1 at r1 (raw file):

<manifest xmlns:android="http://schemas.android.com/apk/res/android"

Is this manifest still needed?

Copy link
Collaborator

@albin-mullvad albin-mullvad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 3 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved


android/app/src/debug/AndroidManifest.xml line 1 at r1 (raw file):

Previously, albin-mullvad wrote…

Is this manifest still needed?

As discussed, it's still needed

@Pururun Pururun force-pushed the remove-testactivity-droid-632 branch 2 times, most recently from f8b3478 to b802b1e Compare January 11, 2024 15:30
@Pururun Pururun force-pushed the remove-testactivity-droid-632 branch from b802b1e to 2a7f99a Compare January 12, 2024 09:58
@Pururun Pururun merged commit 7bcf10a into main Jan 12, 2024
14 checks passed
@Pururun Pururun deleted the remove-testactivity-droid-632 branch January 12, 2024 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Android Issues related to Android
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants