Add mockapi test for handling too many devices

[Pururun]

---

This change is 

[linear]

DROID-587 Automate device tests using mockapi

[albin-mullvad]

Reviewed 4 of 5 files at r1.
Reviewable status: 4 of 5 files reviewed, 1 unresolved discussion (waiting on @Pururun)

---

android/test/mockapi/src/main/kotlin/net/mullvad/mullvadvpn/test/mockapi/MockApiDispatcher.kt line 58 at r1 (raw file):

            "$DEVICES_URL_PATH/$DUMMY_ID_3",
            "$DEVICES_URL_PATH/$DUMMY_ID_4",
            "$DEVICES_URL_PATH/$DUMMY_ID_5" -> {

Can this bit be made more dynamic so that the test case can control it? I believe the same can be said for handleDeviceListRequest.

Code quote:

            "$DEVICES_URL_PATH/$DUMMY_ID_1",
            "$DEVICES_URL_PATH/$DUMMY_ID_2",
            "$DEVICES_URL_PATH/$DUMMY_ID_3",
            "$DEVICES_URL_PATH/$DUMMY_ID_4",
            "$DEVICES_URL_PATH/$DUMMY_ID_5" -> {

[albin-mullvad]

Reviewed 1 of 2 files at r3, all commit messages.
Reviewable status: 4 of 5 files reviewed, 3 unresolved discussions (waiting on @Pururun)

---

android/test/mockapi/src/main/kotlin/net/mullvad/mullvadvpn/test/mockapi/MockApiDispatcher.kt line 32 at r3 (raw file):

    var accountExpiry: DateTime? = null
    var devices: MutableMap<String, String> =
        mapOf(DUMMY_ID_1 to DUMMY_DEVICE_NAME_1).toMutableMap()

Might be a good idea to make sure the test case have to explicitly set this in order to make it transparent to the test case writer/reader. I'm aware that this was more or less hard-coded before, so not really a new issue. We ofc don't want too much boiler plate either. My suggestion is to define a default device list that can be easily set in the dispatcher. This pre-defined list can be set like below or using some extension function etc:

apiDispatcher.apply {
    devices = DEFAULT_DEVICES
}

Code quote:

mapOf(DUMMY_ID_1 to DUMMY_DEVICE_NAME_1).toMutableMap()

---

android/test/mockapi/src/main/kotlin/net/mullvad/mullvadvpn/test/mockapi/MockApiDispatcher.kt line 36 at r3 (raw file):

        get() = devices.size < 5

    var createDevice = DUMMY_ID_2 to DUMMY_DEVICE_NAME_2

I suggest clarifying the name a bit and to skip the default, since that should be up to the test case. This would result in something like this:

val devicePendingToGetCreated: Device? = null

Code quote:

var createDevice = DUMMY_ID_2 to DUMMY_DEVICE_NAME_2

[Pururun]

Reviewable status: 2 of 8 files reviewed, 3 unresolved discussions (waiting on @albin-mullvad)

---

android/test/mockapi/src/main/kotlin/net/mullvad/mullvadvpn/test/mockapi/MockApiDispatcher.kt line 58 at r1 (raw file):

Previously, albin-mullvad wrote…

Can this bit be made more dynamic so that the test case can control it? I believe the same can be said for handleDeviceListRequest.

Done.

---

android/test/mockapi/src/main/kotlin/net/mullvad/mullvadvpn/test/mockapi/MockApiDispatcher.kt line 32 at r3 (raw file):

Previously, albin-mullvad wrote…

Might be a good idea to make sure the test case have to explicitly set this in order to make it transparent to the test case writer/reader. I'm aware that this was more or less hard-coded before, so not really a new issue. We ofc don't want too much boiler plate either. My suggestion is to define a default device list that can be easily set in the dispatcher. This pre-defined list can be set like below or using some extension function etc:

apiDispatcher.apply {
    devices = DEFAULT_DEVICES
}

Done.

---

android/test/mockapi/src/main/kotlin/net/mullvad/mullvadvpn/test/mockapi/MockApiDispatcher.kt line 36 at r3 (raw file):

Previously, albin-mullvad wrote…

I suggest clarifying the name a bit and to skip the default, since that should be up to the test case. This would result in something like this:

val devicePendingToGetCreated: Device? = null

Done.

[albin-mullvad]

Reviewed 6 of 6 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved

[albin-mullvad]

Reviewed 2 of 2 files at r5, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved