Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix android test runner label #5776

Merged
merged 2 commits into from
Feb 7, 2024

Conversation

albin-mullvad
Copy link
Collaborator

@albin-mullvad albin-mullvad commented Feb 6, 2024

This PR aims to correct the android test runner label. The changed label also enables a second test runner which has been configured with the same label (android-device).

Fixes: DROID-638


This change is Reviewable

@albin-mullvad albin-mullvad added the Android Issues related to Android label Feb 6, 2024
@albin-mullvad albin-mullvad self-assigned this Feb 6, 2024
Copy link

linear bot commented Feb 6, 2024

Copy link

linear bot commented Feb 6, 2024

@albin-mullvad albin-mullvad requested a review from Pururun February 6, 2024 16:05
Copy link
Contributor

@Pururun Pururun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Copy link
Contributor

@Rawa Rawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@albin-mullvad albin-mullvad force-pushed the fix-android-test-runner-label-droid-672 branch from 9b27d88 to 926acb7 Compare February 7, 2024 14:14
@albin-mullvad albin-mullvad requested a review from Pururun February 7, 2024 14:16
This label change also enables a second test runner.
This fix ensures that the script can be run by multiple
users on the same machine.
@albin-mullvad albin-mullvad force-pushed the fix-android-test-runner-label-droid-672 branch from 926acb7 to 45575e5 Compare February 7, 2024 14:55
Copy link
Contributor

@Pururun Pururun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@albin-mullvad albin-mullvad merged commit 20d9c98 into main Feb 7, 2024
14 of 15 checks passed
@albin-mullvad albin-mullvad deleted the fix-android-test-runner-label-droid-672 branch February 7, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Android Issues related to Android
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants