Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky account history mockapi test #5786

Merged
merged 1 commit into from
Feb 7, 2024

Conversation

Pururun
Copy link
Contributor

@Pururun Pururun commented Feb 7, 2024

Add some extra time to for the login page to show to improve stability of the test.


This change is Reviewable

@Pururun Pururun added the Android Issues related to Android label Feb 7, 2024
@Pururun Pururun requested a review from Rawa February 7, 2024 14:37
Copy link

linear bot commented Feb 7, 2024

Copy link
Contributor

@Rawa Rawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check that it actually solves it in CI, if that is the case I'm okay with it!

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@Pururun Pururun force-pushed the fix-flaky-account-history-test-droid-676 branch from ac6937f to 5c0d66b Compare February 7, 2024 15:19
Copy link
Collaborator

@albin-mullvad albin-mullvad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Add some extra time to for the login page to show to
improve stability of the test.
@Pururun Pururun force-pushed the fix-flaky-account-history-test-droid-676 branch from 5c0d66b to 65ef484 Compare February 7, 2024 22:04
@Pururun Pururun merged commit 4227f4a into main Feb 7, 2024
11 checks passed
@Pururun Pururun deleted the fix-flaky-account-history-test-droid-676 branch February 7, 2024 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Android Issues related to Android
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants