Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UI for saving a custom list #5807

Closed
wants to merge 1 commit into from

Conversation

rablador
Copy link
Contributor

@rablador rablador commented Feb 13, 2024

The user should be able to save a custom list to disk through a modal popup. Please note that the final design and text is not set yet, so there might be slight differences between current implementation and current design, as well as between current and final implementation.

You can test the new view by removing the exisiting code and pasting the following in TunnelViewController -> viewDidLoad() -> contentView.actionHandler -> .selectLocation. When you press the select location button you'll instead get the alert.

let viewModel = CustomListSaveAlertViewModel()
var alert = CustomListSaveAlert(viewModel: viewModel)

alert.didTapSave = { _ in
    viewModel.inputIsValid = Bool.random()
}

alert.didTapCancel = {
    self.dismiss(animated: true)
}

let vc = UIHostingController(rootView: alert)
vc.view.backgroundColor = .clear
vc.modalPresentationStyle = .overFullScreen
vc.modalTransitionStyle = .crossDissolve

present(vc, animated: true)

image


This change is Reviewable

@rablador rablador added the iOS Issues related to iOS label Feb 13, 2024
Copy link

linear bot commented Feb 13, 2024

@rablador rablador force-pushed the add-ui-for-saving-a-custom-list-ios-509 branch from 2fe3dff to 19bb461 Compare February 13, 2024 13:14
@rablador rablador force-pushed the add-ui-for-saving-a-custom-list-ios-509 branch from 19bb461 to 98ce0f7 Compare February 13, 2024 13:54
@rablador rablador closed this Feb 13, 2024
@rablador rablador deleted the add-ui-for-saving-a-custom-list-ios-509 branch March 5, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
iOS Issues related to iOS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant