-
Notifications
You must be signed in to change notification settings - Fork 369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GitHub actions workflow for iOS end to end tests #5824
GitHub actions workflow for iOS end to end tests #5824
Conversation
aeff5fb
to
00bcb10
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 7 of 7 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @niklasberglund)
.github/workflows/ios-end-to-end-tests.yml
line 79 at r1 (raw file):
uses: actions/upload-artifact@v4 with: name: test-report
Would it make sense to have a unique name for each report ? Or maybe something to identify test results better ?
ios/MullvadVPNUITests/README.md
line 24 at r1 (raw file):
- `curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh` - `rustup target add install aarch64-apple-ios aarch64-apple-ios-sim` 9. Install Go 1.19 [https://go.dev/dl/](https://go.dev/dl/)
We should specify here to install via brew
as that's what we use in the BuildInstructions.md
fileSpecifically via the following command
brew install [email protected]`
00bcb10
to
bbfc87e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 6 of 7 files reviewed, 2 unresolved discussions (waiting on @buggmagnet)
.github/workflows/ios-end-to-end-tests.yml
line 79 at r1 (raw file):
Previously, buggmagnet wrote…
Would it make sense to have a unique name for each report ? Or maybe something to identify test results better ?
I think we should look at runs in the fork together and see if it makes sense
ios/MullvadVPNUITests/README.md
line 24 at r1 (raw file):
Previously, buggmagnet wrote…
We should specify here to install via
brew
as that's what we use in theBuildInstructions.md
fileSpecifically via the following command
brew install [email protected]`
Yes 👍 Changed to it in new revision
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @niklasberglund)
.github/workflows/ios-end-to-end-tests.yml
line 79 at r1 (raw file):
Previously, niklasberglund (Niklas Berglund) wrote…
I think we should look at runs in the fork together and see if it makes sense
Sounds good, let's do that 👍
bbfc87e
to
c3c9d36
Compare
GitHub workflow and related changes for running login tests when pull requests are merged to
main
. Started adding information to README which should be relevant for this PR, more information will also be added to README according to the ticket https://linear.app/mullvad/issue/IOS-479/write-readme-for-ui-testsThe workflow is not runnable until after this has been merged. After merge it can be manually triggered from https://github.com/mullvad/mullvadvpn-app/actions and will also be automatically triggered for each PR merge into
main
.Failed test runs are reported in the form of a comment on the PR with the failed merge. Link to the failed run is included.
This change is