Add problem report test

[niklasberglund]

Created test for submitting problem reports. On stagemole all problem reports are ignored and not sent to support, therefor the current implementation fails if not running against stagemole in order to avoid spamming support. Please let me know if you have feedback on this approach. Without any safeguard it would be easy to accidentally run the test against production.

This PR includes some fixes to the MullvadVPNUITests build configuration to make the Staging configuration run - before it was only set up for Debug configuration . continueAfterFailure = false was also moved from AccountTests to BaseUITestCase so that it is set for all tests, not only tests under AccountTests.

To test this PR run testSendProblemReport under SettingsTests. Note that you need to change to run Staging configuration(Debug is the default configuration) and NO_TIME_ACCOUNT_NUMBER and HAS_TIME_ACCOUNT_NUMBER must be set for Staging configuration:

NO_TIME_ACCOUNT_NUMBER[config=Debug] = <production-account-number-here>
NO_TIME_ACCOUNT_NUMBER[config=Staging] = <staging-account-number-here>
HAS_TIME_ACCOUNT_NUMBER[config=Debug] = <production-account-number-here>
HAS_TIME_ACCOUNT_NUMBER[config=Staging] = <staging-account-number-here>

---

This change is 

[linear]

IOS-439 Test problem reports

[acb-mv]

Reviewed 10 of 10 files at r1, all commit messages.
Reviewable status: 0 of 10 files reviewed, all discussions resolved (waiting on @mojganii and @rablador)

[buggmagnet]

Reviewed 8 of 10 files at r1, all commit messages.
Reviewable status: 0 of 10 files reviewed, 4 unresolved discussions (waiting on @acb-mv, @mojganii, @niklasberglund, and @rablador)

---

ios/MullvadVPN.xcodeproj/project.pbxproj line 605 at r1 (raw file):

		8529693A2B4F0238007EAD4C /* TermsOfServicePage.swift in Sources */ = {isa = PBXBuildFile; fileRef = 852969392B4F0238007EAD4C /* TermsOfServicePage.swift */; };
		8529693C2B4F0257007EAD4C /* Alert.swift in Sources */ = {isa = PBXBuildFile; fileRef = 8529693B2B4F0257007EAD4C /* Alert.swift */; };
		8532E6872B8CCED600ACECD1 /* ProblemReportSubmittedPage.swift in Sources */ = {isa = PBXBuildFile; fileRef = 8532E6862B8CCED600ACECD1 /* ProblemReportSubmittedPage.swift */; };

Don't forget to order files by name when you add a new file

---

ios/MullvadVPN.xcodeproj/project.pbxproj line 7485 at r1 (raw file):

		A93A1D062B59145C00F7796C /* Staging */ = {
			isa = XCBuildConfiguration;
			baseConfigurationReference = 852969382B4ED818007EAD4C /* UITests.xcconfig */;

Curious about these changes, was there something that was not configured properly in the xcode project file ?

---

ios/MullvadVPNUITests/AccountTests.swift line 12 at r1 (raw file):

class AccountTests: LoggedOutUITestCase {
    override func setUpWithError() throws {

⚠️ Unneeded Overridden Functions Violation: Remove overridden functions that don't do anything except call their super (unneeded_override)

---

ios/MullvadVPNUITests/SettingsTests.swift line 14 at r1 (raw file):

class SettingsTests: LoggedOutUITestCase {
    func testSendProblemReport() throws {
        #if !MULLVAD_ENVIRONMENT_STAGING

Instead of doing this (which also leaves a permanent warning when not running the staging environmnent which is not great)

We can do the following

#if !MULLVAD_ENVIRONMENT_STAGING
let shouldSkipTest = true
#else
let shouldSkipTest = false
#endif

try XCTSkipIf(shouldSkipTest, "This test should only run in the Staging environment")

[niklasberglund]

Reviewable status: 0 of 10 files reviewed, 4 unresolved discussions (waiting on @acb-mv, @buggmagnet, @mojganii, and @rablador)

---

ios/MullvadVPN.xcodeproj/project.pbxproj line 605 at r1 (raw file):

Previously, buggmagnet wrote…

Don't forget to order files by name when you add a new file

Oops, will remember next time. Ordered by name now.

---

ios/MullvadVPN.xcodeproj/project.pbxproj line 7485 at r1 (raw file):

Previously, buggmagnet wrote…

Curious about these changes, was there something that was not configured properly in the xcode project file ?

The Debug configuration for MullvadVPNUITests target was correctly set up before but not Staging and MockRelease. Previously I've only been running tests against production so was unaffected, but since this test runs on staging I've been using Staging configuration and encountered issues.

---

ios/MullvadVPNUITests/AccountTests.swift line 12 at r1 (raw file):

Previously, buggmagnet wrote…

⚠️ Unneeded Overridden Functions Violation: Remove overridden functions that don't do anything except call their super (unneeded_override)

Removed 👍

---

ios/MullvadVPNUITests/SettingsTests.swift line 14 at r1 (raw file):

Previously, buggmagnet wrote…

Instead of doing this (which also leaves a permanent warning when not running the staging environmnent which is not great)

We can do the following

#if !MULLVAD_ENVIRONMENT_STAGING
let shouldSkipTest = true
#else
let shouldSkipTest = false
#endif

try XCTSkipIf(shouldSkipTest, "This test should only run in the Staging environment")

That's much better! Have changed it.

[rablador]

Reviewed 7 of 10 files at r1, 3 of 3 files at r2, all commit messages.
Reviewable status: 0 of 10 files reviewed, 4 unresolved discussions (waiting on @acb-mv, @buggmagnet, @mojganii, and @rablador)

[buggmagnet]

Reviewed 3 of 3 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved