Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug where location list is empty on release build #5902

Conversation

rablador
Copy link
Contributor

@rablador rablador commented Mar 5, 2024

Release builds don't currently contain custom lists, which unintentionally stops all locations list to be populated as well.


This change is Reviewable

@rablador rablador added bug iOS Issues related to iOS labels Mar 5, 2024
@rablador rablador requested review from buggmagnet and mojganii March 5, 2024 15:30
Copy link

linear bot commented Mar 5, 2024

Copy link
Contributor

@buggmagnet buggmagnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: 0 of 1 files reviewed, all discussions resolved

@buggmagnet buggmagnet merged commit b90afeb into main Mar 5, 2024
5 of 6 checks passed
@buggmagnet buggmagnet deleted the fix-bug-where-location-list-is-empty-on-release-build-ios-543 branch March 5, 2024 15:45
Copy link
Collaborator

@mojganii mojganii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: 0 of 1 files reviewed, all discussions resolved

Copy link

github-actions bot commented Mar 6, 2024

🚨 End to end tests failed. Please check the failed workflow run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug iOS Issues related to iOS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants