Fix broken UI tests #5916
Merged
Fix broken UI tests #5916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rablador
commented
Mar 7, 2024
There was a problem hiding this comment.
Reviewable status: 0 of 8 files reviewed, 1 unresolved discussion
ios/MullvadVPN/View controllers/SelectLocation/LocationCellViewModel.swift line 16 at r1 (raw file):
var indentationLevel = 0 func hash(into hasher: inout Hasher) {
Previouslt thought unnecessary, but is important for automatic cell selection when view is presented.
rablador
force-pushed
the
fix-broken-ui-tests-ios-545
branch
from
4ce2801 to
d5f42e8
Compare
buggmagnet
approved these changes
Mar 7, 2024
There was a problem hiding this comment.
Reviewed 8 of 8 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion
|
🚨 End to end tests failed. Please check the failed workflow run. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After doing some changes on the UI for custom lists, we broke our UI Automated tests. Also improves location node matching to avoid possibly duplicated node codes in the future.
This change is