-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move IP Overrides into VPN Settings menu #5971
Move IP Overrides into VPN Settings menu #5971
Conversation
23b3fef
to
be56075
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 25 files reviewed, 3 unresolved discussions
ios/MullvadSettings/SettingsManager.swift
line 147 at r1 (raw file):
logger.debug("Reset store.") let keys = completely ? SettingsKey.allCases : [.settings, .deviceState, .apiAccessMethods, .ipOverrides]
This has apparently been missed.
ios/MullvadVPN/Coordinators/Settings/IPOverride/IPOverrideViewController.swift
line 150 at r1 (raw file):
On some networks, where various types of censorship are being used, our server IP addresses are \ sometimes blocked. To circumvent this you can import a file or a text, provided by our support team, \
Removed some spaces that would make alert text look bad.
ios/MullvadVPN/View controllers/VPNSettings/VPNSettingsViewController.swift
line 137 at r1 (raw file):
value: """ The automatic setting will randomly choose from the valid port ranges shown below. The custom port can be any value inside the valid ranges:
Removed some spaces that would make alert text look bad.
be56075
to
c583c80
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 9 of 22 files at r1, 16 of 16 files at r2, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 9 of 22 files at r1, 16 of 16 files at r2, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions
c583c80
to
1ddc41a
Compare
Currently resides in top level menu under settings, but should reside under submenu item VPN Settings.
This change is![Reviewable](https://camo.githubusercontent.com/1541c4039185914e83657d3683ec25920c672c6c5c7ab4240ee7bff601adec0b/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)