Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing cities and relays in custom list #6147

Merged

Conversation

Pururun
Copy link
Contributor

@Pururun Pururun commented Apr 18, 2024

Bug introduced in a previous PR.


This change is Reviewable

@Pururun Pururun added the Android Issues related to Android label Apr 18, 2024
@Pururun Pururun requested review from Rawa and albin-mullvad April 18, 2024 08:52
@Pururun Pururun self-assigned this Apr 18, 2024
Copy link

linear bot commented Apr 18, 2024

Copy link
Collaborator

@albin-mullvad albin-mullvad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Pururun)

a discussion (no related file):
Would be nice to cover this with some tests. But if this will change a lot during the gRPC work we can probably skip it for now.


Copy link
Contributor

@Rawa Rawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Pururun)

Copy link
Contributor

@Rawa Rawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @albin-mullvad)

a discussion (no related file):

Previously, albin-mullvad wrote…

Would be nice to cover this with some tests. But if this will change a lot during the gRPC work we can probably skip it for now.

Yeah if the logic is spread out I think it might be hard, but otherwise I think it would be nice to have. Let's discuss.


Copy link
Contributor

@Rawa Rawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @albin-mullvad)

Copy link
Collaborator

@albin-mullvad albin-mullvad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@Pururun Pururun force-pushed the relay-and-city-items-not-showing-in-custom-list-droid-909 branch from 288eee7 to c0b5ad7 Compare April 18, 2024 13:27
@Pururun Pururun merged commit 0819505 into main Apr 18, 2024
26 checks passed
@Pururun Pururun deleted the relay-and-city-items-not-showing-in-custom-list-droid-909 branch April 18, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Android Issues related to Android
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants