Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump minimum target deployment to 15.0 #6801

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

mojganii
Copy link
Collaborator

@mojganii mojganii commented Sep 17, 2024

This PR bumps the minimum deployment target version to iOS 15.0.


This change is Reviewable

Copy link

linear bot commented Sep 17, 2024

@mojganii mojganii self-assigned this Sep 17, 2024
@mojganii mojganii added the iOS Issues related to iOS label Sep 17, 2024
Copy link
Contributor

@rablador rablador left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 6 of 6 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @mojganii)


ios/MullvadVPN/Extensions/NSDiffableDataSourceSnapshot+Reconfigure.swift line 18 at r1 (raw file):

            reconfigureItems(itemIdentifiers)
        } else {
            reloadItems(itemIdentifiers)

I believe this reloadItems() function can be removed altogether.

Copy link
Collaborator Author

@mojganii mojganii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @rablador)


ios/MullvadVPN/Extensions/NSDiffableDataSourceSnapshot+Reconfigure.swift line 18 at r1 (raw file):

Previously, rablador (Jon Petersson) wrote…

I believe this reloadItems() function can be removed altogether.

that's true.

@mojganii mojganii force-pushed the drop-support-for-ios-14_2-ios-785 branch from d46d718 to f67d13b Compare September 17, 2024 11:28
Copy link
Contributor

@buggmagnet buggmagnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 6 files at r1, 6 of 6 files at r2, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @mojganii and @rablador)


ios/MullvadTypes/Duration.swift line 14 at r2 (raw file):

/// drop-in replacement until the app supports iOS16. Ideally this whole file can
/// then be deleted without affecting the rest of the code base.
@available(iOS, introduced: 15.0, obsoleted: 16.0, message: "Replace with native Duration type.")

nit
Out of curiosity, did we need to bump this number (and al the others as well) when setting the minimum target to 15? 🤔

Copy link
Contributor

@rablador rablador left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 6 of 6 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @mojganii)

Copy link
Collaborator Author

@mojganii mojganii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @buggmagnet)


ios/MullvadTypes/Duration.swift line 14 at r2 (raw file):

Previously, buggmagnet wrote…

nit
Out of curiosity, did we need to bump this number (and al the others as well) when setting the minimum target to 15? 🤔

I did that to match with the version we're already supporting. it was not crucial to be changed.

@mojganii mojganii force-pushed the drop-support-for-ios-14_2-ios-785 branch from f67d13b to e6df320 Compare September 18, 2024 10:27
@buggmagnet buggmagnet force-pushed the drop-support-for-ios-14_2-ios-785 branch from e6df320 to 5bbb719 Compare September 18, 2024 10:42
@buggmagnet buggmagnet merged commit a8c1ca3 into main Sep 18, 2024
8 of 9 checks passed
@buggmagnet buggmagnet deleted the drop-support-for-ios-14_2-ios-785 branch September 18, 2024 10:45
Copy link

🚨 End to end tests failed. Please check the failed workflow run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
iOS Issues related to iOS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants