-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump minimum target deployment to 15.0 #6801
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 6 of 6 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @mojganii)
ios/MullvadVPN/Extensions/NSDiffableDataSourceSnapshot+Reconfigure.swift
line 18 at r1 (raw file):
reconfigureItems(itemIdentifiers) } else { reloadItems(itemIdentifiers)
I believe this reloadItems()
function can be removed altogether.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @rablador)
ios/MullvadVPN/Extensions/NSDiffableDataSourceSnapshot+Reconfigure.swift
line 18 at r1 (raw file):
Previously, rablador (Jon Petersson) wrote…
I believe this
reloadItems()
function can be removed altogether.
that's true.
d46d718
to
f67d13b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 4 of 6 files at r1, 6 of 6 files at r2, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @mojganii and @rablador)
ios/MullvadTypes/Duration.swift
line 14 at r2 (raw file):
/// drop-in replacement until the app supports iOS16. Ideally this whole file can /// then be deleted without affecting the rest of the code base. @available(iOS, introduced: 15.0, obsoleted: 16.0, message: "Replace with native Duration type.")
nit
Out of curiosity, did we need to bump this number (and al the others as well) when setting the minimum target to 15? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 6 of 6 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @mojganii)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @buggmagnet)
ios/MullvadTypes/Duration.swift
line 14 at r2 (raw file):
Previously, buggmagnet wrote…
nit
Out of curiosity, did we need to bump this number (and al the others as well) when setting the minimum target to 15? 🤔
I did that to match with the version we're already supporting. it was not crucial to be changed.
f67d13b
to
e6df320
Compare
e6df320
to
5bbb719
Compare
🚨 End to end tests failed. Please check the failed workflow run. |
This PR bumps the minimum deployment target version to iOS 15.0.
This change is![Reviewable](https://camo.githubusercontent.com/1541c4039185914e83657d3683ec25920c672c6c5c7ab4240ee7bff601adec0b/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)