Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not truncate settings.json #7423

Conversation

Serock3
Copy link
Contributor

@Serock3 Serock3 commented Jan 7, 2025


This change is Reviewable

@Serock3 Serock3 added the Daemon Issues related to mullvad-daemon label Jan 7, 2025
@Serock3 Serock3 self-assigned this Jan 7, 2025
Copy link

linear bot commented Jan 7, 2025

Copy link
Contributor

@MarkusPettersson98 MarkusPettersson98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @Serock3)


test/test-runner/src/logging.rs line 129 at r1 (raw file):

    path: T,
    truncate_lines: Option<usize>,
) -> io::Result<String> {

Could we document the truncate_lines parameter? 😊

Code quote:

async fn read_truncated<T: AsRef<Path>>(
    path: T,
    truncate_lines: Option<usize>,
) -> io::Result<String> {

Copy link
Contributor Author

@Serock3 Serock3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @MarkusPettersson98)


test/test-runner/src/logging.rs line 129 at r1 (raw file):

Previously, MarkusPettersson98 (Markus Pettersson) wrote…

Could we document the truncate_lines parameter? 😊

Done.

Copy link
Contributor

@MarkusPettersson98 MarkusPettersson98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@Serock3 Serock3 marked this pull request as ready for review January 8, 2025 13:01
Copy link
Contributor

@MarkusPettersson98 MarkusPettersson98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@Serock3 Serock3 force-pushed the start-of-settingsjson-is-missing-from-debug-print-in-test-des-1610 branch from a99d5e4 to a88510a Compare January 9, 2025 13:19
@Serock3 Serock3 merged commit b01de0b into main Jan 9, 2025
38 of 40 checks passed
@Serock3 Serock3 deleted the start-of-settingsjson-is-missing-from-debug-print-in-test-des-1610 branch January 9, 2025 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Daemon Issues related to mullvad-daemon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants