-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not truncate settings.json
#7423
Do not truncate settings.json
#7423
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @Serock3)
test/test-runner/src/logging.rs
line 129 at r1 (raw file):
path: T, truncate_lines: Option<usize>, ) -> io::Result<String> {
Could we document the truncate_lines
parameter? 😊
Code quote:
async fn read_truncated<T: AsRef<Path>>(
path: T,
truncate_lines: Option<usize>,
) -> io::Result<String> {
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @MarkusPettersson98)
test/test-runner/src/logging.rs
line 129 at r1 (raw file):
Previously, MarkusPettersson98 (Markus Pettersson) wrote…
Could we document the
truncate_lines
parameter? 😊
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! all files reviewed, all discussions resolved
a99d5e4
to
a88510a
Compare
This change is