Add back missing app icon on Windows #7448
Merged
+0
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign installer & add metadata to the produced binary / app installer. Without this option enabled, the electron app was missing the Mullvad app icon. This option was disabled by accident, and the default value is also true.
hulthe
approved these changes
Jan 10, 2025
MarkusPettersson98
deleted the
desktop-icon-is-the-electron-logo-des-1605
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable the
signAndEditExecutableelectron-builder option, which allows electron-builder to add metadata to the produced binary / app installer. Without this option enabled, the electron app was missing the Mullvad app icon. This option was disabled by accident, and the default value is also true.Here are the relevant electron-builder docs: https://www.electron.build/win.html#signandeditexecutable
This change is