-
Notifications
You must be signed in to change notification settings - Fork 369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix daita settings view on ios 15 #7465
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved
3793483
to
95e7ae7
Compare
This should now work on iOS 15, 16, 17 and 18. Large font should not truncate the text |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 2 files at r1, 1 of 1 files at r4, 1 of 1 files at r5, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @SteffenErn)
ios/MullvadVPN/Coordinators/Settings/Views/SettingsInfoView.swift
line 31 at r5 (raw file):
ZStack { // Renders (and hide) the content of each page, to push the view to the maximum possible size. VStack {
I think we should move this out to a separate function for clarity and less clutter, as it's not really part of the intended structure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r4, 1 of 1 files at r5, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @SteffenErn)
f2b329a
to
4fc0216
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed. I pushed a cleaner solution
Reviewable status: 2 of 3 files reviewed, 1 unresolved discussion (waiting on @buggmagnet and @rablador)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r6, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @SteffenErn)
If you change the commit message to comply with the brutal conformism of the CI, I'll merge this :) |
47a873c
to
be2b477
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 2 files at r1, 1 of 1 files at r5, 1 of 1 files at r7, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @SteffenErn)
be2b477
to
e753280
Compare
e753280
to
3b7982f
Compare
🚨 End to end tests failed. Please check the failed workflow run. |
DAITA settings view was broken on iOS 15 devices due to SwiftUI List bug. This PR fixes the issue by using ScrollView instead.
This change is