Position location marker on the map correctly ios 993

[buggmagnet]

This PR deletes the SwiftUI spinner view and retvrns to tradition by re-introducing SpinnerActivityIndicatorView into TunnelViewController.

Additionally, the map and spinner will be centered higher on the map so it doesn't get obscured by the newly introduced ConnectionView written in SwiftUI.
The spinner position varies slightly based on the available screen estate, typically, it will be positioned higher on devices with less than 700 pixels in height.

---

This change is 

[linear]

IOS-993 Position location marker on the map correctly

[rablador]

Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @buggmagnet)

---

ios/MullvadVPN/View controllers/Tunnel/TunnelViewController.swift line 227 at r1 (raw file):

    }

    private func addContentView() {

This func should probably be called addConnectionView and the spinner be added in separate function.

[buggmagnet]

Reviewable status: 4 of 5 files reviewed, 1 unresolved discussion (waiting on @rablador)

---

ios/MullvadVPN/View controllers/Tunnel/TunnelViewController.swift line 227 at r1 (raw file):

Previously, rablador (Jon Petersson) wrote…

This func should probably be called addConnectionView and the spinner be added in separate function.

Done.

[SteffenErn]

Reviewed 4 of 5 files at r1, 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @rablador)

[rablador]

Reviewed 1 of 1 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved

[github-actions]

🚨 End to end tests failed. Please check the failed workflow run.