Remove most default-members to speed up builds and reduce duplication
#7494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlon
approved these changes
Jan 21, 2025
There was a problem hiding this comment.
Reviewed 5 of 5 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved
faern
force-pushed
the
remove-all-libraries-from-default-members-des-1657
branch
from
5f7ef52 to
692c562
Compare
faern
force-pushed
the
remove-all-libraries-from-default-members-des-1657
branch
from
692c562 to
109f1b1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We included almost every crate in
default-members. All crates exceptwindows-installerwhich could not build without specific inputs as to what installers to include (it built a full universal installer, bundling arch specific installers at build time). This list had a lot of duplication and seems like a bit of a mess to maintain.Since our workspace also contained virtually everything, a simple
cargo buildbuilt everything, which might not be desired from a build time perspective. This PR reduce thedefault-membersto some "sane default" bare minimum. It includesmullvad-daemonandmullvad-clibecause those are the main binaries, and anyone building this project is most likely after those binaries. It also includesmullvad-versionsince we have a ton of invocations tocargo run --bin mullvad-version, and that does not work if the crate is not a default crate. We could also update all those invocations to add an extra-p mullvad-versionto solve the issue. But I felt like the version computation binary was central enough to be included as a default crate 🤷This change is