Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash on showing alert for in-app purchase #7499

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

mojganii
Copy link
Collaborator

@mojganii mojganii commented Jan 22, 2025

This pr fixes the crash problem in showing alert for adding more time.


This change is Reviewable

@mojganii mojganii added the iOS Issues related to iOS label Jan 22, 2025
@mojganii mojganii self-assigned this Jan 22, 2025
Copy link

linear bot commented Jan 22, 2025

Copy link
Contributor

@rablador rablador left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @mojganii)


ios/MullvadVPN/Extensions/UIAlertController+InAppPurchase.swift line 29 at r1 (raw file):

        )
        actionSheet.overrideUserInterfaceStyle = .dark
        actionSheet.view.tintColor = UIColor(red: 0.0, green: 0.59, blue: 1.0, alpha: 1)

We're using the same color in custom lists, right? If so, I think we should put it in the UIColor extensions.

@mojganii mojganii force-pushed the fix-display-aciton-sheet-on-ipad-ios-1028 branch from 3c17283 to a8fb7eb Compare January 22, 2025 14:02
Copy link
Collaborator Author

@mojganii mojganii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 3 files reviewed, 1 unresolved discussion (waiting on @rablador)


ios/MullvadVPN/Extensions/UIAlertController+InAppPurchase.swift line 29 at r1 (raw file):

Previously, rablador (Jon Petersson) wrote…

We're using the same color in custom lists, right? If so, I think we should put it in the UIColor extensions.

yes, we do. let's do that then

@mojganii mojganii requested a review from rablador January 22, 2025 14:03
Copy link
Contributor

@SteffenErn SteffenErn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @rablador)

Copy link
Contributor

@acb-mv acb-mv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @rablador)

Copy link
Contributor

@rablador rablador left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@mojganii mojganii force-pushed the fix-display-aciton-sheet-on-ipad-ios-1028 branch from a8fb7eb to 47d25e6 Compare January 22, 2025 14:53
@rablador rablador merged commit 060839d into main Jan 22, 2025
11 checks passed
@rablador rablador deleted the fix-display-aciton-sheet-on-ipad-ios-1028 branch January 22, 2025 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
iOS Issues related to iOS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants