Fix testWireGuardOverTCPAutomatically and testConnectionRetryLogic #7502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rablador
force-pushed
the
fix-testwireguardovertcpautomatically-and-ios-1027
branch
from
2ec8e5f to
e1ad75a
Compare
buggmagnet
approved these changes
Jan 22, 2025
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved
rablador
force-pushed
the
fix-testwireguardovertcpautomatically-and-ios-1027
branch
from
e1ad75a to
4f75066
Compare
mojganii
approved these changes
Jan 23, 2025
There was a problem hiding this comment.
The CI and local environment fail to run RelayTests that most are related to partner api then I approve your PR since your changes has nothing to do those problems.
Reviewable status:
rablador
force-pushed
the
fix-testwireguardovertcpautomatically-and-ios-1027
branch
from
4f75066 to
ba52fcb
Compare
rablador
deleted the
fix-testwireguardovertcpautomatically-and-ios-1027
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this needs to be done
The above tests are failing after merging feature indicator views, which is reason enough to fix them.
https://github.com/mullvad/mullvadvpn-app/actions/runs/12871536677/job/35885195591
What needs to be done
The running theory is that these tests rely on the connection view being expanded, but you might need to do further investigation.
Acceptance criteria
This change is