Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade ipnetwork to 0.21 #121

Merged
merged 1 commit into from
Jan 8, 2025
Merged

Upgrade ipnetwork to 0.21 #121

merged 1 commit into from
Jan 8, 2025

Conversation

MarkusPettersson98
Copy link
Contributor

@MarkusPettersson98 MarkusPettersson98 commented Jan 6, 2025

This PR upgrade ipnetwork to 0.21.1. This version is specified because of a regression in 0.21.0 that was resolved by this fix.

Other than including some bugfixes this release also removes serde as a default dependency, making it opt-in instead. pfctl-rs does not use serde, so this is a small benefit pfctl-rs consumers may get by upgrading ipnetwork.


This change is Reviewable

@MarkusPettersson98 MarkusPettersson98 marked this pull request as draft January 6, 2025 12:42
Copy link
Member

@faern faern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a breaking change, since ipnetwork is part of the public API. https://github.com/mullvad/pfctl-rs/blob/main/CHANGELOG.md#changed-1

This also means that we can't use this new version until we bump ipnetwork in our workspace. But that's doable!

I like the change overall, we should of course stay up to date, and getting rid of a dependency is nice (provides no direct value to our bigger project since serde is a dependency there anyway, but for other consumers!)
:lgtm:

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@MarkusPettersson98 MarkusPettersson98 marked this pull request as ready for review January 7, 2025 19:59
@MarkusPettersson98
Copy link
Contributor Author

Nice to hear that you are onboard! I do look forward to some improvements in the new version of ipnetwork 0.21 such as achanda/ipnetwork#203, but we are currently blocked from upgrading ipnetwork in the app repository because of the aforementioned public API breakage 😅

Copy link
Member

@faern faern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved


Cargo.toml line 22 at r2 (raw file):

libc = "0.2.29"
derive_builder = "0.20"
ipnetwork = "0.21.1"

Technically we don't need to enforce the .1 part on library users here, do we`. Pfctl is not affected by the bug fixen in that patch release? But not going to block this PR on it.

Copy link
Contributor Author

@MarkusPettersson98 MarkusPettersson98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved


Cargo.toml line 22 at r2 (raw file):

Previously, faern (Linus Färnstrand) wrote…

Technically we don't need to enforce the .1 part on library users here, do we`. Pfctl is not affected by the bug fixen in that patch release? But not going to block this PR on it.

I figured we kind of have to, since 0.21.0 is buggy and it surfaced as errors in our CI / tests :(

Copy link
Member

@faern faern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved


Cargo.toml line 22 at r2 (raw file):

Previously, MarkusPettersson98 (Markus Pettersson) wrote…

I figured we kind of have to, since 0.21.0 is buggy and it surfaced as errors in our CI / tests :(

Aah, ok! I was not aware it was messing with our own CI. Yeah, then we need to bump the patch also. Don't mind me :)

@MarkusPettersson98 MarkusPettersson98 merged commit 2134037 into main Jan 8, 2025
8 checks passed
@MarkusPettersson98 MarkusPettersson98 deleted the upgrade-ipnetwork branch January 8, 2025 14:45
@pronebird
Copy link
Contributor

Please consider making a release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants