-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade ipnetwork
to 0.21
#121
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a breaking change, since ipnetwork
is part of the public API. https://github.com/mullvad/pfctl-rs/blob/main/CHANGELOG.md#changed-1
This also means that we can't use this new version until we bump ipnetwork
in our workspace. But that's doable!
I like the change overall, we should of course stay up to date, and getting rid of a dependency is nice (provides no direct value to our bigger project since serde is a dependency there anyway, but for other consumers!)
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved
e9ced39
to
b8d791d
Compare
Nice to hear that you are onboard! I do look forward to some improvements in the new version of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 3 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved
Cargo.toml
line 22 at r2 (raw file):
libc = "0.2.29" derive_builder = "0.20" ipnetwork = "0.21.1"
Technically we don't need to enforce the .1
part on library users here, do we`. Pfctl is not affected by the bug fixen in that patch release? But not going to block this PR on it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! all files reviewed, all discussions resolved
Cargo.toml
line 22 at r2 (raw file):
Previously, faern (Linus Färnstrand) wrote…
Technically we don't need to enforce the
.1
part on library users here, do we`. Pfctl is not affected by the bug fixen in that patch release? But not going to block this PR on it.
I figured we kind of have to, since 0.21.0
is buggy and it surfaced as errors in our CI / tests :(
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! all files reviewed, all discussions resolved
Cargo.toml
line 22 at r2 (raw file):
Previously, MarkusPettersson98 (Markus Pettersson) wrote…
I figured we kind of have to, since
0.21.0
is buggy and it surfaced as errors in our CI / tests :(
Aah, ok! I was not aware it was messing with our own CI. Yeah, then we need to bump the patch also. Don't mind me :)
b8d791d
to
0a34fb0
Compare
Please consider making a release. |
This PR upgrade ipnetwork to 0.21.1. This version is specified because of a regression in 0.21.0 that was resolved by this fix.
Other than including some bugfixes this release also removes
serde
as a default dependency, making it opt-in instead.pfctl-rs
does not useserde
, so this is a small benefitpfctl-rs
consumers may get by upgradingipnetwork
.This change is