Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace audit check on PR push with periodical job #27

Closed
wants to merge 1 commit into from

Conversation

faern
Copy link
Member

@faern faern commented Mar 24, 2022

While fiddling with the CI and checking out the https://github.com/actions-rs organization for various Rust related Github Actions actions I found the audit-check action. Seems way simpler to use than the way we installed and ran cargo audit.

I'm adding this both as a scheduled job and on each PR. It's relevant in PRs if the PR changes the dependency tree. And it's relevant as a scheduled job since CVEs can pop up at any time even when the dependency tree is not changing.


This change is Reviewable

@faern faern requested a review from dlon March 24, 2022 13:57
@faern faern force-pushed the improve-audit-ci branch from 77323d0 to 4a06d90 Compare March 24, 2022 13:59
@faern
Copy link
Member Author

faern commented Mar 24, 2022

Never mind this PR. The following issue makes the cargo-audit plugin somewhat useless for this crate: actions-rs/audit-check#163

@faern faern closed this Mar 24, 2022
@faern faern deleted the improve-audit-ci branch March 24, 2022 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant