Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deployment instructions for generic servers #22

Merged
merged 9 commits into from
Oct 19, 2020
Merged

Conversation

JackWilb
Copy link
Member

@JackWilb JackWilb commented Oct 7, 2020

Adds instructions for building and deploying the client and the API.

TODO:

@JackWilb JackWilb marked this pull request as ready for review October 9, 2020 20:32
@JackWilb JackWilb requested review from jjnesbitt and waxlamp October 9, 2020 20:32
Copy link
Member

@jjnesbitt jjnesbitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job with this, just a few suggestions

generic_deployment.rst Outdated Show resolved Hide resolved
generic_deployment.rst Outdated Show resolved Hide resolved
generic_deployment.rst Outdated Show resolved Hide resolved
generic_deployment.rst Outdated Show resolved Hide resolved
generic_deployment.rst Outdated Show resolved Hide resolved
@JackWilb JackWilb requested a review from jjnesbitt October 14, 2020 16:55
generic_deployment.rst Outdated Show resolved Hide resolved
@JackWilb JackWilb requested a review from jjnesbitt October 14, 2020 17:10
Copy link
Contributor

@waxlamp waxlamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. Please follow Jake's approval/requests in getting this merged.

jjnesbitt
jjnesbitt previously approved these changes Oct 15, 2020
Copy link
Member

@jjnesbitt jjnesbitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@JackWilb JackWilb merged commit 98acb77 into master Oct 19, 2020
@JackWilb JackWilb deleted the deploy-docs branch October 19, 2020 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants