Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add block proof support #1454

Open
wants to merge 2 commits into
base: development
Choose a base branch
from

Conversation

bogdan-rosianu
Copy link
Contributor

Reasoning

  • new (not yet released) versions of the protocol (andromeda) have 2 new fields on blocks

Proposed Changes

  • return these 2 new fields if they exist
  • the object just needed to be extended, because the deserialization will fill them

How to test

@bogdan-rosianu bogdan-rosianu self-assigned this Feb 21, 2025
Copy link

github-actions bot commented Feb 21, 2025

k6 load testing comparison.
Base Commit Hash: 887bd0b
Target Commit Hash: 785c1c1

Metric Base Target Diff
AvgMax9095AvgMax9095AvgMax9095
Mex48.85690.8953.0154.7949.79190.5754.9556.99+1.93% 🔴-72.42% ✅+3.66% 🔴+4.03% 🔴
Transactions65.822319.0654.0857.2169.812459.2855.6759.84+6.05% 🔴+6.05% 🔴+2.94% 🔴+4.59% 🔴
Blocks56.301711.5753.3556.0057.381456.4455.8059.29+1.92% 🔴-14.91% ✅+4.58% 🔴+5.87% 🔴
Nodes49.571188.6553.0755.0850.13472.1854.9356.93+1.13% 🔴-60.28% ✅+3.51% 🔴+3.37% 🔴
Pool48.50399.3552.9054.6849.97315.7154.9556.97+3.04% 🔴-20.94% ✅+3.87% 🔴+4.18% 🔴
Accounts49.931544.6352.9254.5051.621630.3754.9757.15+3.38% 🔴+5.55% 🔴+3.87% 🔴+4.85% 🔴
Tokens48.73524.3352.9454.7950.29606.1054.9356.94+3.21% 🔴+15.59% 🔴+3.75% 🔴+3.93% 🔴
Test Run Duration60004.7060005.15

Legend: Avg - Average Response Time, Max - Maximum Response Time, 90 - 90th Percentile, 95 - 95th Percentile
All times are in milliseconds.

@bogdan-rosianu bogdan-rosianu marked this pull request as ready for review February 26, 2025 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants