Invalid deposit transactions tests #381
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- deposits with less amount - bridges to address zero - deposits of non whitelisted tokens
# Conflicts: # integrationTests/relayers/slowTests/framework/multiversxHandler.go # integrationTests/relayers/slowTests/framework/testSetup.go
| IsFaultyDeposit: true, | ||
| }, | ||
| }, | ||
| ESDTSafeExtraBalance: big.NewInt(100), // extra is just for the fees for the 2 transfers mvx->eth |
There was a problem hiding this comment.
this should be 0, the swaps are not done, no values should be held in the ESDT safe
| @@ -236,6 +275,82 @@ func GenerateTestMEXToken() framework.TestTokenParams { | |||
| } | |||
| } | |||
|
|
|||
| // GenerateTestDOGEToken will generate a test DOGE token | |||
| func GenerateTestDOGEToken() framework.TestTokenParams { | |||
There was a problem hiding this comment.
GenerateUnlistedTokenFromEth?
I think it is a good idea to change in a future PR all test token names
| } | ||
|
|
||
| // GenerateTestBOBERToken will generate a test BOBER token | ||
| func GenerateTestBOBERToken() framework.TestTokenParams { |
There was a problem hiding this comment.
GenerateUnlistedTokenFromMvx?
I think it is a good idea to change in a future PR all test token names
| { | ||
| ValueToTransferToMvx: nil, | ||
| ValueToSendFromMvX: big.NewInt(2010), | ||
| MvxSCCallData: createScCallData("callPayable", 50000000), |
There was a problem hiding this comment.
this is irrelevant for this token
| MvxSCCallData: createScCallData("callPayable", 50000000), | ||
| }, | ||
| }, | ||
| ESDTSafeExtraBalance: big.NewInt(150), // just the fees should be collected in ESDT safe |
| @@ -551,7 +481,10 @@ func (handler *MultiversxHandler) issueAndWhitelistTokensWithChainSpecific(ctx c | |||
| handler.setLocalRolesForUniversalTokenOnWrapper(ctx, params) | |||
There was a problem hiding this comment.
I would reconsider this a little bit. What do we need for an unlisted token?
issue at least the universal token
mint the Alice user with some funds for this token
All L481-L494 are not done for an unlisted token.
- there is a mistake as handler.whitelistTokenOnMultisig(ctx, params) is called twice
| @@ -569,7 +502,9 @@ func (handler *MultiversxHandler) issueAndWhitelistTokens(ctx context.Context, p | |||
|
|
|||
| handler.setRolesForSpecificTokenOnSafe(ctx, params) | |||
| handler.addMappingInMultisig(ctx, params) | |||
| handler.whitelistTokenOnMultisig(ctx, params) | |||
| if !params.PreventWhitelist { | |||
| return len(responseData) != 0 | ||
| } | ||
|
|
||
| func (handler *MultiversxHandler) sendAndCheckTx(ctx context.Context, sender KeysHolder, receiver *MvxAddress, value string, gasLimit uint64, function string, params []string) (string, *data.TransactionOnNetwork) { |
There was a problem hiding this comment.
This is actually scCallAndCheckTx :)
| @@ -32,6 +33,22 @@ const ( | |||
|
|
|||
| type currentBridge string | |||
|
|
|||
| type CurrentActorState struct { | |||
| if !setup.checkHolderEthBalanceForToken(sender, true, params) { | ||
| // if token is prevented from whitelist, we can't check the balances | ||
| if params.PreventWhitelist { | ||
| return true |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.