No transfer role integration test #420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # integrationTests/relayers/slowTests/ethToMultiversXWithChainSimulator_test.go # integrationTests/relayers/slowTests/framework/multiversxHandler.go # integrationTests/relayers/slowTests/refundWithChainSimulator_test.go # integrationTests/relayers/slowTests/testdata/contracts/mvx/bridge-proxy.abi.json # integrationTests/relayers/slowTests/testdata/contracts/mvx/bridge-proxy.wasm # integrationTests/relayers/slowTests/testdata/contracts/mvx/bridged-tokens-wrapper.abi.json # integrationTests/relayers/slowTests/testdata/contracts/mvx/bridged-tokens-wrapper.wasm # integrationTests/relayers/slowTests/testdata/contracts/mvx/esdt-safe.abi.json # integrationTests/relayers/slowTests/testdata/contracts/mvx/esdt-safe.wasm # integrationTests/relayers/slowTests/testdata/contracts/mvx/multi-transfer-esdt.abi.json # integrationTests/relayers/slowTests/testdata/contracts/mvx/multi-transfer-esdt.wasm # integrationTests/relayers/slowTests/testdata/contracts/mvx/multisig.abi.json # integrationTests/relayers/slowTests/testdata/contracts/mvx/multisig.wasm # integrationTests/relayers/slowTests/testdata/contracts/mvx/test-caller.abi.json # integrationTests/relayers/slowTests/testdata/contracts/mvx/test-caller.wasm
# Conflicts: # integrationTests/relayers/slowTests/testdata/contracts/mvx/bridge-proxy.wasm # integrationTests/relayers/slowTests/testdata/contracts/mvx/bridged-tokens-wrapper.wasm # integrationTests/relayers/slowTests/testdata/contracts/mvx/esdt-safe.wasm # integrationTests/relayers/slowTests/testdata/contracts/mvx/helper-contract.wasm # integrationTests/relayers/slowTests/testdata/contracts/mvx/multi-transfer-esdt.wasm # integrationTests/relayers/slowTests/testdata/contracts/mvx/multisig.wasm # integrationTests/relayers/slowTests/testdata/contracts/mvx/multiversx-price-aggregator-sc.abi.json # integrationTests/relayers/slowTests/testdata/contracts/mvx/multiversx-price-aggregator-sc.wasm # integrationTests/relayers/slowTests/testdata/contracts/mvx/test-caller.wasm
| t.Run("refunds should work with tokens with transfer role", func(t *testing.T) { | ||
| // usdc token | ||
| usdcToken := slowTests.GetSimplerVersionOfUSDCToken() | ||
| usdcToken.AddressesWithTransferRole = []string{framework.Alice, framework.SafeSC, framework.MultiTransfer, framework.ScProxy} |
There was a problem hiding this comment.
Reminder for myself: document this
| getFunction string, | ||
| withdrawFunction string, | ||
| ) { | ||
| queryParams := []string{ |
There was a problem hiding this comment.
maybe extract L1135-L1156 in a function and use it on L1082 to remove the duplicated code?
| @@ -290,8 +290,8 @@ func (setup *TestSetup) AreAllTransfersCompleted(halfBridgeIdentifier HalfBridge | |||
| } | |||
|
|
|||
| func (setup *TestSetup) isTransferDone(halfBridgeIdentifier HalfBridgeIdentifier, token TestTokenParams) bool { | |||
| // if token is prevented from whitelist, we can't check the balances | |||
| if token.PreventWhitelist { | |||
| // if token is prevented from whitelist or alice don't have the permission to transfer it, we can't check the balances | |||
| @@ -534,4 +535,4 @@ | |||
| ] | |||
| } | |||
| } | |||
| } | |||
| } | |||
iulianpascalau
approved these changes
Feb 24, 2025
sstanculeanu
approved these changes
Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added e2e test for these 4 scenarios:
Refactoring