Integrated new contracts with the blacklist functionality #427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- added complex scenario as e2e test involving the blacklist functionality
cosmatudor
previously approved these changes
Feb 24, 2025
| testFlowEthToMvx *slowTests.TestFlow, | ||
| failedTransactionNotifier FailedTransactionNotifier, | ||
| ) { | ||
| log.Info(fmt.Sprintf(testMarker, "Starting step 1 - swaps that do not work for tokens without transfer role")) |
There was a problem hiding this comment.
I think this log is not very informative. The token does have the role activated, but it's not assigned to the correct addresses.
There was a problem hiding this comment.
will rephrase
sstanculeanu
previously approved these changes
Feb 24, 2025
# Conflicts: # integrationTests/relayers/slowTests/framework/multiversxHandler.go # integrationTests/relayers/slowTests/testdata/contracts/mvx/esdt-safe.wasm # integrationTests/relayers/slowTests/testdata/contracts/mvx/multi-transfer-esdt.abi.json # integrationTests/relayers/slowTests/testdata/contracts/mvx/multi-transfer-esdt.wasm # integrationTests/relayers/slowTests/testdata/contracts/mvx/multisig.abi.json # integrationTests/relayers/slowTests/testdata/contracts/mvx/multisig.wasm
iulianpascalau
dismissed stale reviews from sstanculeanu and cosmatudor
via
4716d19
cosmatudor
approved these changes
Feb 24, 2025
sstanculeanu
approved these changes
Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference PR: multiversx/mx-bridge-eth-sc-rs#280