Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix double rendering #1357

Merged
merged 3 commits into from
Jan 14, 2025
Merged

Fix double rendering #1357

merged 3 commits into from
Jan 14, 2025

Conversation

arhtudormorar
Copy link
Contributor

@arhtudormorar arhtudormorar commented Jan 14, 2025

Issue

Dapps load twice on page refresh

Reproduce

Refresh the page and watch the network tab

Issue exists on version 3.1.6 of sdk-dapp.

Root cause

Authenticated routes wrapper switches between rendering null and rendering children

Fix

Stop the switch if account data is already available

Additional changes

Revert ledger-hq alpha version

Contains breaking changes

  • No
  • Yes

Updated CHANGELOG

  • No
  • Yes

Testing

  • User testing
  • Unit tests

@arhtudormorar arhtudormorar changed the base branch from main to development January 14, 2025 08:29
@arhtudormorar arhtudormorar merged commit bf66ce4 into development Jan 14, 2025
3 checks passed
@arhtudormorar arhtudormorar deleted the tm/fix/double-rendering branch January 14, 2025 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants