Toast for cancel sign message does not show #995
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Cancelling a sign message does not display a toast with a specified message.
Reproduce
Issue exists on version
2.25.2
of sdk-dapp.Root cause
Sign message URL params does not contain
signSession
in order foruseParseSignedTransactions
to be able to intercept and display the message.Fix
Instead of adding a new param for the URL, use directly
setSignTransactionsCancelMessage
in order to display theerrorMessage
.Additional changes
Contains breaking changes
[x] No
[] Yes
Updated CHANGELOG
[x] Yes
Testing
[x] User testing
[] Unit tests