-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/gonumplot #272
base: master
Are you sure you want to change the base?
Feature/gonumplot #272
Conversation
The plot in the web gui is no longer created by a gnuplot subprocess. The gonum/plot package is used to create the plot instead.
Looks neat, but I will give it a closer look. |
@JeroenMulkers
|
I can confirm that the gonum's plot works very well on Windows. I have also seen several times "broken pipe" errors. |
@JeroenMulkers In addition, I would suggest to not add brackets to labels if units are empty. |
These two changes drastically reduce the number of broken pipe errors. However, there are still disadvantages of using gonum/plot over gnuplot:
I will consider the attempt of changing the plot engine as a fun exercise, but for the above mentioned disadvantages I believe it is better to stick with gnuplot. |
@JeroenMulkers I still think it would be a good idea to have go-native visualization, assuming the backend is properly maintained. |
This pull request changes how the plot in the web gui is created. Instead of calling gnuplot, the gonum/plot package will be used to create the plot.
The advantages of using gonum/plot over gnuplot are: