Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace grcov with tarpaulin for test coverage #100

Merged
merged 1 commit into from
Mar 23, 2020

Conversation

baszalmstra
Copy link
Collaborator

@baszalmstra baszalmstra commented Mar 21, 2020

So from my point of view these are the pros and cons of using tarpaulin over grcov:

Pros

  • Seems to give more precise coverage
  • Better integration in the rust ecosystem
  • Actively developed.

Cons

  • Still has false positives
  • Only runs on Ubuntu (so no coverage on macOS and Windows specific paths)
  • Might still be unstable because it was in the past

@baszalmstra baszalmstra self-assigned this Mar 21, 2020
@codecov
Copy link

codecov bot commented Mar 21, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@00cb85a). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #100   +/-   ##
=========================================
  Coverage          ?   77.78%           
=========================================
  Files             ?      134           
  Lines             ?     8806           
  Branches          ?        0           
=========================================
  Hits              ?     6850           
  Misses            ?     1956           
  Partials          ?        0           
Impacted Files Coverage Δ
crates/mun_hir/src/macros.rs 100.00% <0.00%> (ø)
crates/mun_codegen/src/intrinsics/macros.rs 100.00% <0.00%> (ø)
crates/mun_syntax/src/parsing/lexer/comments.rs 100.00% <0.00%> (ø)
crates/mun_hir/src/in_file.rs 45.45% <0.00%> (ø)
crates/mun_compiler/src/diagnostics/emit.rs 0.00% <0.00%> (ø)
crates/tools/src/runtime_capi.rs 100.00% <0.00%> (ø)
crates/mun_runtime/src/test.rs 97.99% <0.00%> (ø)
crates/mun_errors/src/location.rs 12.50% <0.00%> (ø)
crates/mun_syntax/src/tests/parser.rs 100.00% <0.00%> (ø)
crates/mun_hir/src/expr/validator/tests.rs 100.00% <0.00%> (ø)
... and 124 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00cb85a...27b4fce. Read the comment docs.

@baszalmstra baszalmstra changed the title WIP: test to replace grcov with tarpaulin for test coverage Replace grcov with tarpaulin for test coverage Mar 21, 2020
@baszalmstra baszalmstra marked this pull request as ready for review March 21, 2020 22:36
@baszalmstra baszalmstra requested a review from Wodann March 21, 2020 22:36
@baszalmstra baszalmstra merged commit c72b965 into mun-lang:master Mar 23, 2020
@Wodann Wodann added this to the Mun v0.2 milestone May 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants