Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(parser): parsing of unmatched right curly braces ('}') #243

Merged
merged 1 commit into from
Jul 15, 2020

Conversation

emigr2k1
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Jul 15, 2020

Codecov Report

Merging #243 into master will not change coverage.
The diff coverage is 50.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #243   +/-   ##
=======================================
  Coverage   81.10%   81.10%           
=======================================
  Files         189      189           
  Lines       12325    12325           
=======================================
  Hits         9996     9996           
  Misses       2329     2329           
Impacted Files Coverage Δ
...tes/mun_syntax/src/parsing/grammar/declarations.rs 88.70% <50.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c872745...62c2a15. Read the comment docs.

@baszalmstra
Copy link
Collaborator

Thanks for this! 👍

@baszalmstra baszalmstra merged commit 59a091b into mun-lang:master Jul 15, 2020
@Wodann
Copy link
Collaborator

Wodann commented Jul 15, 2020

Thanks for finding and fixing this bug @emigr2k1.

A recommendation for the future would be to also add a test that causes the crash to our test suite - along with the fix. That way we can check for regressions, going forward :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants