Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: removed outdated comments #245

Merged
merged 1 commit into from
Jul 17, 2020
Merged

Conversation

eopb
Copy link
Contributor

@eopb eopb commented Jul 17, 2020

These comments are misleading as the functions do not return bools

@baszalmstra baszalmstra changed the title Removed possibly outdated comments. improvement: removed possibly outdated comments Jul 17, 2020
@baszalmstra baszalmstra changed the title improvement: removed possibly outdated comments improvement: removed outdated comments Jul 17, 2020
@baszalmstra
Copy link
Collaborator

baszalmstra commented Jul 17, 2020

We try to follow the Conventional Commits format as outlined in our contributing guide. Could you update your commit messages to reflect that?

@baszalmstra baszalmstra added the type: fix Bug fix or report label Jul 17, 2020
@baszalmstra baszalmstra changed the title improvement: removed outdated comments fix: removed outdated comments Jul 17, 2020
@eopb eopb force-pushed the outdated-comments branch from 8c2bed1 to f2e3cb4 Compare July 17, 2020 13:41
@eopb
Copy link
Contributor Author

eopb commented Jul 17, 2020

@baszalmstra Done.

@codecov
Copy link

codecov bot commented Jul 17, 2020

Codecov Report

Merging #245 into master will increase coverage by 1.83%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #245      +/-   ##
==========================================
+ Coverage   78.94%   80.78%   +1.83%     
==========================================
  Files         196      189       -7     
  Lines       12608    12239     -369     
==========================================
- Hits         9954     9887      -67     
+ Misses       2654     2352     -302     
Impacted Files Coverage Δ
crates/mun/src/lib.rs 52.10% <ø> (ø)
crates/mun_language_server/tests/support.rs 80.85% <0.00%> (-0.79%) ⬇️
crates/mun_hir/src/db.rs 100.00% <0.00%> (ø)
crates/mun_compiler_daemon/src/lib.rs 0.00% <0.00%> (ø)
crates/mun_language_server/src/lib.rs 0.00% <0.00%> (ø)
crates/mun_language_server/src/capabilities.rs 0.00% <0.00%> (ø)
crates/mun_syntax/src/syntax_kind/generated.rs 65.44% <0.00%> (ø)
crates/mun_language_server/src/conversion.rs
crates/mun_language_server/src/analysis.rs
crates/mun_language_server/src/change.rs
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98979ca...7f137c0. Read the comment docs.

@baszalmstra
Copy link
Collaborator

If you rebase on current master the CI will no longer fail.

These comments are misleading as the functions do not return `bool`s
@eopb eopb force-pushed the outdated-comments branch from f2e3cb4 to 7f137c0 Compare July 17, 2020 14:25
@eopb
Copy link
Contributor Author

eopb commented Jul 17, 2020

@baszalmstra Done

@baszalmstra baszalmstra merged commit 0635c2d into mun-lang:master Jul 17, 2020
@eopb eopb deleted the outdated-comments branch September 1, 2020 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: fix Bug fix or report
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants