Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move library loading logic to separate crate #252

Merged
merged 1 commit into from
Aug 22, 2020

Conversation

Wodann
Copy link
Collaborator

@Wodann Wodann commented Aug 22, 2020

No description provided.

@Wodann Wodann added the type: refactor Refactor existing code label Aug 22, 2020
@Wodann Wodann added this to the Mun v0.3.0 milestone Aug 22, 2020
@Wodann Wodann requested a review from baszalmstra August 22, 2020 15:57
@Wodann Wodann self-assigned this Aug 22, 2020
@codecov
Copy link

codecov bot commented Aug 22, 2020

Codecov Report

Merging #252 into master will increase coverage by 0.01%.
The diff coverage is 76.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #252      +/-   ##
==========================================
+ Coverage   79.09%   79.11%   +0.01%     
==========================================
  Files         200      201       +1     
  Lines       12749    12767      +18     
==========================================
+ Hits        10084    10100      +16     
- Misses       2665     2667       +2     
Impacted Files Coverage Δ
crates/mun_libloader/src/temp_library.rs 88.88% <ø> (ø)
crates/mun_runtime/tests/util.rs 83.63% <ø> (ø)
crates/mun_libloader/src/lib.rs 72.00% <72.00%> (ø)
crates/mun_runtime/src/assembly.rs 69.14% <100.00%> (+2.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aef4492...5220f83. Read the comment docs.

@baszalmstra baszalmstra merged commit 0dcbed3 into mun-lang:master Aug 22, 2020
@Wodann Wodann deleted the refactor/libloading branch August 22, 2020 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: refactor Refactor existing code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants