Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: generate C ABI from Rust code #255

Merged
merged 1 commit into from
Aug 23, 2020
Merged

Conversation

Wodann
Copy link
Collaborator

@Wodann Wodann commented Aug 23, 2020

Previously the Rust ABI was generated from the C ABI

Depends on:

To do:

  • Set submodules to their respective master branches, after the above PRs have been merged.

@Wodann Wodann added the type: refactor Refactor existing code label Aug 23, 2020
@Wodann Wodann added this to the Mun v0.3.0 milestone Aug 23, 2020
@Wodann Wodann requested a review from baszalmstra August 23, 2020 10:05
@Wodann Wodann self-assigned this Aug 23, 2020
Previously the Rust ABI was generated from the C ABI
@codecov
Copy link

codecov bot commented Aug 23, 2020

Codecov Report

Merging #255 into master will increase coverage by 0.06%.
The diff coverage is 93.86%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #255      +/-   ##
==========================================
+ Coverage   79.10%   79.16%   +0.06%     
==========================================
  Files         201      203       +2     
  Lines       12807    12717      -90     
==========================================
- Hits        10131    10068      -63     
+ Misses       2676     2649      -27     
Impacted Files Coverage Δ
crates/mun_memory/tests/diff/util.rs 83.18% <ø> (ø)
crates/mun_runtime/src/lib.rs 68.31% <0.00%> (-4.32%) ⬇️
crates/mun_abi/src/function_info.rs 84.81% <80.32%> (-15.19%) ⬇️
crates/mun_abi/src/struct_info.rs 86.44% <86.44%> (ø)
crates/mun_codegen/tests/abi.rs 95.94% <95.94%> (ø)
crates/mun_abi/src/dispatch_table.rs 97.46% <97.46%> (ø)
crates/mun_abi/src/assembly_info.rs 100.00% <100.00%> (ø)
crates/mun_abi/src/module_info.rs 100.00% <100.00%> (ø)
crates/mun_abi/src/test_utils.rs 100.00% <100.00%> (ø)
crates/mun_abi/src/type_info.rs 81.95% <100.00%> (+13.12%) ⬆️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a6b437...fd717ce. Read the comment docs.

@Wodann Wodann merged commit 7bc27ba into mun-lang:master Aug 23, 2020
@Wodann Wodann deleted the refactor/abi branch August 23, 2020 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: refactor Refactor existing code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants