Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: emit and link bitcode files instead of obj does not work on MacOS #261

Merged
merged 1 commit into from
Aug 29, 2020

Conversation

baszalmstra
Copy link
Collaborator

This reverts commit 0736239 or MR #258 . It doesnt work when generating MacOS binaries (build actually failed..).

For MacOS we would have to generate object files so we would have two code paths. Id rather then just use object files for all platforms.

@baszalmstra baszalmstra added this to the Mun v0.3.0 milestone Aug 29, 2020
@baszalmstra baszalmstra requested a review from Wodann August 29, 2020 12:12
@baszalmstra baszalmstra self-assigned this Aug 29, 2020
@codecov
Copy link

codecov bot commented Aug 29, 2020

Codecov Report

Merging #261 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #261   +/-   ##
=======================================
  Coverage   78.74%   78.75%           
=======================================
  Files         215      215           
  Lines       12853    12857    +4     
=======================================
+ Hits        10121    10125    +4     
  Misses       2732     2732           
Impacted Files Coverage Δ
crates/mun_codegen/src/code_gen.rs 100.00% <ø> (ø)
crates/mun_codegen/src/code_gen/module_builder.rs 75.00% <100.00%> (+1.31%) ⬆️
crates/mun_codegen/src/code_gen/object_file.rs 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 742ddeb...4e2fcc6. Read the comment docs.

@baszalmstra baszalmstra merged commit d9ebc18 into mun-lang:master Aug 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants