Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: 7zip issues #280

Merged
merged 1 commit into from
Oct 10, 2020
Merged

fix: 7zip issues #280

merged 1 commit into from
Oct 10, 2020

Conversation

baszalmstra
Copy link
Collaborator

@baszalmstra baszalmstra commented Oct 10, 2020 •
edited
Loading

Recently we have some issues with the windows build this is a PR to hopefully fix these issues.

Fixes #281

@baszalmstra baszalmstra added type: fix Bug fix or report pri: intermediate An issue resulting in non-critical functionality loss and no significant effect on usability labels Oct 10, 2020
@baszalmstra baszalmstra self-assigned this Oct 10, 2020
@baszalmstra baszalmstra force-pushed the fix/dont_use_external_7zip branch 2 times, most recently from 07d4748 to 05a4732 Compare October 10, 2020 11:31
@codecov
Copy link

codecov bot commented Oct 10, 2020 •
edited
Loading

Codecov Report

Merging #280 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #280   +/-   ##
=======================================
  Coverage   78.82%   78.82%           
=======================================
  Files         220      220           
  Lines       13070    13070           
=======================================
  Hits        10303    10303           
  Misses       2767     2767

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d818fe3...600409a. Read the comment docs.

@baszalmstra baszalmstra force-pushed the fix/dont_use_external_7zip branch 3 times, most recently from 5f01a92 to 7474f98 Compare October 10, 2020 11:45
@baszalmstra baszalmstra force-pushed the fix/dont_use_external_7zip branch from 7474f98 to 600409a Compare October 10, 2020 11:45
@baszalmstra baszalmstra changed the title fix: dont use external 7zip fix: 7zip issues Oct 10, 2020
@Wodann Wodann merged commit d806389 into mun-lang:master Oct 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wodann Wodann Wodann approved these changes

Assignees

@baszalmstra baszalmstra

Labels
pri: intermediate An issue resulting in non-critical functionality loss and no significant effect on usability type: fix Bug fix or report
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

7zip fails on CI
2 participants
@baszalmstra @Wodann