Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(codegen): alignment of struct fields #285

Merged
merged 1 commit into from
Oct 24, 2020
Merged

fix(codegen): alignment of struct fields #285

merged 1 commit into from
Oct 24, 2020

Conversation

Wodann
Copy link
Collaborator

@Wodann Wodann commented Oct 23, 2020

Fixes #274.

@Wodann Wodann added the type: fix Bug fix or report label Oct 23, 2020
@Wodann Wodann added this to the Mun v0.3.0 milestone Oct 23, 2020
@Wodann Wodann requested a review from baszalmstra October 23, 2020 13:19
@Wodann Wodann self-assigned this Oct 23, 2020
@codecov
Copy link

codecov bot commented Oct 23, 2020 •
edited
Loading

Codecov Report

Merging #285 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #285   +/-   ##
=======================================
  Coverage   79.39%   79.39%           
=======================================
  Files         220      220           
  Lines       13004    13004           
=======================================
  Hits        10324    10324           
  Misses       2680     2680
Impacted Files Coverage Δ
crates/mun_codegen/src/ir/types.rs 75.00% <ø> (ø)
crates/mun_codegen/src/code_gen/symbols.rs 94.69% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48e1a86...b70fe84. Read the comment docs.

@Wodann Wodann force-pushed the fix/struct-field-alignment branch from 25f6894 to 64942d9 Compare October 23, 2020 13:56
baszalmstra
baszalmstra requested changes Oct 24, 2020
View reviewed changes
Copy link
Collaborator

@baszalmstra baszalmstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks very good! Thanks! 👍

Most of my comments are about adding some comments, I find it hard to figure out exactly what is going on.

crates/mun_codegen/src/ir/types.rs Show resolved Hide resolved
crates/mun_codegen_macros/src/lib.rs Outdated Show resolved Hide resolved
crates/mun_codegen_macros/src/lib.rs Outdated Show resolved Hide resolved
crates/mun_codegen_macros/src/lib.rs Outdated Show resolved Hide resolved
crates/mun_codegen_macros/src/lib.rs Outdated Show resolved Hide resolved
crates/mun_codegen_macros/src/lib.rs Show resolved Hide resolved
crates/mun_codegen_macros/src/lib.rs Show resolved Hide resolved
crates/mun_codegen_macros/src/lib.rs Show resolved Hide resolved
crates/mun_codegen_macros/src/lib.rs Show resolved Hide resolved
crates/mun_codegen/Cargo.toml Show resolved Hide resolved
@Wodann Wodann force-pushed the fix/struct-field-alignment branch from 64942d9 to 2ce4f50 Compare October 24, 2020 11:54
@Wodann Wodann force-pushed the fix/struct-field-alignment branch from 2ce4f50 to b70fe84 Compare October 24, 2020 12:45
@Wodann Wodann closed this Oct 24, 2020
@Wodann Wodann force-pushed the fix/struct-field-alignment branch from b70fe84 to 48e1a86 Compare October 24, 2020 12:46
@Wodann Wodann reopened this Oct 24, 2020
@baszalmstra baszalmstra merged commit 31bee34 into mun-lang:master Oct 24, 2020
@Wodann Wodann deleted the fix/struct-field-alignment branch October 24, 2020 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baszalmstra baszalmstra baszalmstra approved these changes

Assignees

@Wodann Wodann

Labels
type: fix Bug fix or report
Projects
None yet
Milestone
Mun v0.3.0
Development

Successfully merging this pull request may close these issues.

The Mun compiler does not properly align struct fields
2 participants
@Wodann @baszalmstra