-
-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(codegen): add AsValue macro support for enums #286
Conversation
2cb5cbf
to
41256ee
Compare
Codecov Report
@@ Coverage Diff @@
## master #286 +/- ##
==========================================
- Coverage 79.39% 79.34% -0.06%
==========================================
Files 220 220
Lines 13004 13069 +65
==========================================
+ Hits 10324 10369 +45
- Misses 2680 2700 +20
Continue to review full report at Codecov.
|
41256ee
to
f647f99
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First little batch, Im gonna wait until this is rebased to get a better overview of the changes. :)
I need to add trivial tests for |
0c8a0cf
to
4cf4ab8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is really nice and also provides a valuable start to add enums to Mun itself!
In general I think it would be good to split the generation of enums and structs in seperate functions, maybe add some more helper functions. This procedural macro function is now almost 700 lines long which IMO is way to long for a single function.
Also, again, some comments explaining what is going on would be nice. Maybe you could even add a little explaination in the docs what the problem is and how it is solved? (Either in the book or as doc comments)
9a04816
to
6454e5f
Compare
6454e5f
to
3e66099
Compare
Closes #275