bump: Inkwell beta.2 and LLVM11 #303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baszalmstra
force-pushed
the
feature/inkwell_beta1
branch
15 times, most recently
from
f8404f7 to
d0211cb
Compare
Codecov Report
@@ Coverage Diff @@
## master #303 +/- ##
==========================================
+ Coverage 80.80% 80.87% +0.07%
==========================================
Files 240 242 +2
Lines 14584 14716 +132
==========================================
+ Hits 11785 11902 +117
- Misses 2799 2814 +15
Continue to review full report at Codecov.
|
baszalmstra
force-pushed
the
feature/inkwell_beta1
branch
2 times, most recently
from
c7b4b18 to
25c896d
Compare
baszalmstra
changed the title
baszalmstra
force-pushed
the
feature/inkwell_beta1
branch
2 times, most recently
from
822e2cb to
ff50a53
Compare
Wodann
reviewed
Feb 20, 2021
| @@ -1,8 +0,0 @@ | |||
| ignore-not-existing: true | |||
There was a problem hiding this comment.
Yes it hasnt been used for a long time now
Wodann
reviewed
Feb 20, 2021
| @@ -132,7 +132,7 @@ source_filename = "group_name" | |||
| @"struct_info::<ValueStruct>::field_names" = private unnamed_addr constant [2 x i8*] [i8* getelementptr inbounds ([2 x i8], [2 x i8]* @"struct_info::<ValueStruct>::field_names.0", i32 0, i32 0), i8* getelementptr inbounds ([2 x i8], [2 x i8]* @"struct_info::<ValueStruct>::field_names.1", i32 0, i32 0)] | |||
| @"struct_info::<ValueStruct>::field_types" = private unnamed_addr constant [2 x %"mun_codegen::ir::types::TypeInfo"*] [%"mun_codegen::ir::types::TypeInfo"* @"type_info::<core::f32>", %"mun_codegen::ir::types::TypeInfo"* @"type_info::<core::f32>"] | |||
| @"struct_info::<ValueStruct>::field_offsets" = private unnamed_addr constant [2 x i16] [i16 0, i16 4] | |||
| @"type_info::<ValueStruct>" = private unnamed_addr constant { %"mun_codegen::ir::types::TypeInfo", %"mun_codegen::ir::types::StructInfo" } { %"mun_codegen::ir::types::TypeInfo" <{ [0 x i64] zeroinitializer, [16 x i8] c"U0{\87\5C\04Q/\95!$\A2\F1\A9\F9W", [0 x i64] zeroinitializer, i8* getelementptr inbounds ([12 x i8], [12 x i8]* @"type_info::<ValueStruct>::name", i32 0, i32 0), [0 x i64] zeroinitializer, i32 64, [0 x i64] zeroinitializer, i8 4, [0 x i64] zeroinitializer, i8 1, [1 x i16] zeroinitializer }>, %"mun_codegen::ir::types::StructInfo" <{ [0 x i64] zeroinitializer, i8** getelementptr inbounds ([2 x i8*], [2 x i8*]* @"struct_info::<ValueStruct>::field_names", i32 0, i32 0), [0 x i64] zeroinitializer, %"mun_codegen::ir::types::TypeInfo"** getelementptr inbounds ([2 x %"mun_codegen::ir::types::TypeInfo"*], [2 x %"mun_codegen::ir::types::TypeInfo"*]* @"struct_info::<ValueStruct>::field_types", i32 0, i32 0), [0 x i64] zeroinitializer, i16* getelementptr inbounds ([2 x i16], [2 x i16]* @"struct_info::<ValueStruct>::field_offsets", i32 0, i32 0), [0 x i64] zeroinitializer, i16 2, [0 x i64] zeroinitializer, i8 1, [5 x i8] zeroinitializer }> } | |||
| @"type_info::<ValueStruct>" = private unnamed_addr constant { %"mun_codegen::ir::types::TypeInfo", %"mun_codegen::ir::types::StructInfo" } { %"mun_codegen::ir::types::TypeInfo" <{ [0 x i64] zeroinitializer, [16 x i8] c"U0{\87\\\04Q/\95!$\A2\F1\A9\F9W", [0 x i64] zeroinitializer, i8* getelementptr inbounds ([12 x i8], [12 x i8]* @"type_info::<ValueStruct>::name", i32 0, i32 0), [0 x i64] zeroinitializer, i32 64, [0 x i64] zeroinitializer, i8 4, [0 x i64] zeroinitializer, i8 1, [1 x i16] zeroinitializer }>, %"mun_codegen::ir::types::StructInfo" <{ [0 x i64] zeroinitializer, i8** getelementptr inbounds ([2 x i8*], [2 x i8*]* @"struct_info::<ValueStruct>::field_names", i32 0, i32 0), [0 x i64] zeroinitializer, %"mun_codegen::ir::types::TypeInfo"** getelementptr inbounds ([2 x %"mun_codegen::ir::types::TypeInfo"*], [2 x %"mun_codegen::ir::types::TypeInfo"*]* @"struct_info::<ValueStruct>::field_types", i32 0, i32 0), [0 x i64] zeroinitializer, i16* getelementptr inbounds ([2 x i16], [2 x i16]* @"struct_info::<ValueStruct>::field_offsets", i32 0, i32 0), [0 x i64] zeroinitializer, i16 2, [0 x i64] zeroinitializer, i8 1, [5 x i8] zeroinitializer }> } | |||
There was a problem hiding this comment.
I'm not sure why this changed
There was a problem hiding this comment.
Looks like something changed from "U0{\87\5C\04Q/\95!$\A2\F1\A9\F9W" to "U0{\87\\\04Q/\95!$\A2\F1\A9\F9W" also not entirely sure why..
There was a problem hiding this comment.
Makes me wonder whether this was previously broken 🤷♂️
If not serious, feel free to merge
Wodann
requested changes
Feb 20, 2021
Wodann
approved these changes
Feb 27, 2021
baszalmstra
force-pushed
the
feature/inkwell_beta1
branch
from
ff50a53 to
72ea35b
Compare
Wodann
added
type: build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates our codebase to use
masterof inkwell. Once inkwellbeta1is published to creates.io I will updates this PR to use that instead.This PR also updates our entire codebase to LLVM11 which contains our fix for LLD. Closes #256 .
This will also clear the way to be able to build a fully statically linked version of Mun (except for libc) on Linux. (See #191 )
Note that I removed the build instructions for Arch because it was already outdated in the first place and I don't know how to update it correctly. If anyone would like to help out with that, let me know! :)