Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add marshalling of structs #83

Merged
merged 5 commits into from
Jan 29, 2020

Conversation

Wodann
Copy link
Collaborator

@Wodann Wodann commented Jan 14, 2020

Depends on #90

@Wodann Wodann requested a review from baszalmstra January 14, 2020 16:16
@Wodann Wodann self-assigned this Jan 14, 2020
@codecov
Copy link

codecov bot commented Jan 14, 2020

Codecov Report

Merging #83 into master will increase coverage by 16.93%.
The diff coverage is 69.52%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #83       +/-   ##
===========================================
+ Coverage   57.49%   74.42%   +16.93%     
===========================================
  Files         119      121        +2     
  Lines        8375     9521     +1146     
===========================================
+ Hits         4815     7086     +2271     
+ Misses       3560     2435     -1125
Impacted Files Coverage Δ
crates/mun_runtime/src/marshal.rs 0% <0%> (ø)
crates/mun_abi/src/lib.rs 0% <0%> (ø) ⬆️
crates/mun_runtime/src/test.rs 96.93% <100%> (+5.04%) ⬆️
crates/tools/src/abi.rs 96.15% <100%> (+54.48%) ⬆️
crates/mun_codegen/src/code_gen/abi_types.rs 100% <100%> (ø) ⬆️
crates/mun_codegen/src/code_gen.rs 77.27% <100%> (+46.5%) ⬆️
crates/mun_runtime/src/lib.rs 83.19% <100%> (+1.29%) ⬆️
crates/mun_abi/src/autogen_impl.rs 95.51% <100%> (+57.07%) ⬆️
crates/mun_runtime/src/reflection.rs 20.51% <20.51%> (ø)
crates/mun_runtime/src/macros.rs 43.54% <47.72%> (+40.32%) ⬆️
... and 62 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e3659c...6e85fa8. Read the comment docs.

Copy link
Collaborator

@baszalmstra baszalmstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mind of we hold off on this PR until I fixed the malloc linking issue correctly?

@Wodann
Copy link
Collaborator Author

Wodann commented Jan 18, 2020

That's totally fine. The temporary fix is cumbersome in CI, so better not waste any more time on it

Copy link
Collaborator

@baszalmstra baszalmstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nicely done!

@Wodann
Copy link
Collaborator Author

Wodann commented Jan 24, 2020

@Wodann Wodann force-pushed the feature/struct-interop branch from 5facf34 to 6e85fa8 Compare January 26, 2020 10:54
@Wodann Wodann requested a review from baszalmstra January 26, 2020 11:00
@Wodann Wodann merged commit 1a5d56a into mun-lang:master Jan 29, 2020
@Wodann Wodann changed the title Add marshalling of structs feat: add marshalling of structs Jan 31, 2020
@Wodann Wodann deleted the feature/struct-interop branch March 25, 2020 11:25
@Wodann Wodann added this to the Mun v0.2 milestone May 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants