Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: size and alignment in type info #98

Merged

Conversation

baszalmstra
Copy link
Collaborator

This PR adds the size and alignment of a type to the TypeInfo and removes these fields from StructInfo since those are now obsolete. I tried created clean commits to be able to clearly see all the changes that went into this PR.

This PR is based on #97.

@codecov
Copy link

codecov bot commented Mar 19, 2020

Codecov Report

Merging #98 into master will increase coverage by 0.00%.
The diff coverage is 84.54%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #98   +/-   ##
=======================================
  Coverage   76.84%   76.84%           
=======================================
  Files         130      132    +2     
  Lines       10569    10643   +74     
=======================================
+ Hits         8122     8179   +57     
- Misses       2447     2464   +17     
Impacted Files Coverage Δ
crates/mun_runtime/src/lib.rs 90.19% <ø> (ø)
crates/tools/src/abi.rs 70.37% <ø> (ø)
crates/mun_codegen/src/ir.rs 55.76% <44.00%> (+8.22%) ⬆️
crates/mun_codegen/src/type_info.rs 64.83% <53.84%> (+8.31%) ⬆️
crates/mun_abi/src/autogen.rs 52.22% <55.55%> (-5.00%) ⬇️
crates/mun_codegen/src/ir/dispatch_table.rs 90.00% <71.42%> (-1.13%) ⬇️
crates/mun_runtime/src/static_type_map.rs 87.50% <87.50%> (ø)
crates/mun_codegen/src/ir/ty.rs 94.00% <95.12%> (+1.59%) ⬆️
crates/mun_runtime/src/type_info.rs 95.89% <95.89%> (ø)
crates/mun_abi/src/autogen_impl.rs 97.64% <100.00%> (-0.14%) ⬇️
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd8111c...e66cbbc. Read the comment docs.

@baszalmstra baszalmstra force-pushed the feature/size_and_alignment_in_type_info branch from bbceec5 to 4066cfd Compare March 20, 2020 08:06
@baszalmstra baszalmstra force-pushed the feature/size_and_alignment_in_type_info branch from c229d71 to d9c5267 Compare March 21, 2020 16:25
@baszalmstra baszalmstra force-pushed the feature/size_and_alignment_in_type_info branch from d9c5267 to 071c19d Compare March 21, 2020 16:32
crates/mun_runtime/src/static_type_map.rs Show resolved Hide resolved
crates/mun_runtime/src/static_type_map.rs Outdated Show resolved Hide resolved
crates/mun_abi/src/autogen_impl.rs Outdated Show resolved Hide resolved
crates/mun_runtime/src/allocator.rs Outdated Show resolved Hide resolved
crates/mun_runtime/src/type_info.rs Outdated Show resolved Hide resolved
crates/mun_abi/src/autogen_impl.rs Outdated Show resolved Hide resolved
crates/mun_abi/src/autogen_impl.rs Outdated Show resolved Hide resolved
crates/mun_abi/src/autogen_impl.rs Outdated Show resolved Hide resolved
crates/mun_runtime/src/type_info.rs Outdated Show resolved Hide resolved
crates/mun_runtime/src/type_info.rs Outdated Show resolved Hide resolved
@baszalmstra baszalmstra force-pushed the feature/size_and_alignment_in_type_info branch from a85cc4c to e0548c9 Compare March 21, 2020 19:47
crates/mun_runtime/Cargo.toml Outdated Show resolved Hide resolved
crates/mun_runtime/src/static_type_map.rs Show resolved Hide resolved
@Wodann Wodann merged commit 82fee48 into mun-lang:master Mar 21, 2020
@Wodann Wodann changed the title Feature/size and alignment in type info feat: size and alignment in type info Mar 21, 2020
baszalmstra pushed a commit to baszalmstra/mun that referenced this pull request Mar 21, 2020
…nment_in_type_info

feat: size and alignment in type info
@Wodann Wodann added this to the Mun v0.2 milestone May 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants