-
-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: size and alignment in type info #98
Merged
Wodann
merged 12 commits into
mun-lang:master
from
baszalmstra:feature/size_and_alignment_in_type_info
Mar 21, 2020
Merged
feat: size and alignment in type info #98
Wodann
merged 12 commits into
mun-lang:master
from
baszalmstra:feature/size_and_alignment_in_type_info
Mar 21, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #98 +/- ##
=======================================
Coverage 76.84% 76.84%
=======================================
Files 130 132 +2
Lines 10569 10643 +74
=======================================
+ Hits 8122 8179 +57
- Misses 2447 2464 +17
Continue to review full report at Codecov.
|
baszalmstra
force-pushed
the
feature/size_and_alignment_in_type_info
branch
from
March 20, 2020 08:06
bbceec5
to
4066cfd
Compare
baszalmstra
force-pushed
the
feature/size_and_alignment_in_type_info
branch
from
March 21, 2020 16:25
c229d71
to
d9c5267
Compare
baszalmstra
force-pushed
the
feature/size_and_alignment_in_type_info
branch
from
March 21, 2020 16:32
d9c5267
to
071c19d
Compare
Wodann
requested changes
Mar 21, 2020
baszalmstra
force-pushed
the
feature/size_and_alignment_in_type_info
branch
from
March 21, 2020 19:47
a85cc4c
to
e0548c9
Compare
Wodann
reviewed
Mar 21, 2020
Wodann
approved these changes
Mar 21, 2020
Wodann
changed the title
Feature/size and alignment in type info
feat: size and alignment in type info
Mar 21, 2020
baszalmstra
pushed a commit
to baszalmstra/mun
that referenced
this pull request
Mar 21, 2020
…nment_in_type_info feat: size and alignment in type info
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
size
andalignment
of a type to theTypeInfo
and removes these fields fromStructInfo
since those are now obsolete. I tried created clean commits to be able to clearly see all the changes that went into this PR.This PR is based on #97.