Merge Runtime C API and C++ bindings #2

Wodann · 2019-11-04T14:38:17Z

Something went wrong with #1 when force pushing that caused the PR to be automatically closed for good.

This PR includes the requested fixes for documentation.

include/mun/invoke_result.h

include/mun/runtime.h

include/mun/runtime_capi.h

baszalmstra

Besides the comment I left, I think logging to cerr is not a proper way of implementing error logging it should at least be configurable.

Also, now that the binaries are in here as well, you can implement tests too right?

The docs are very nice. :)

include/mun/runtime.h

Wodann requested a review from baszalmstra November 4, 2019 14:38

Wodann self-assigned this Nov 4, 2019

baszalmstra suggested changes Nov 4, 2019

View reviewed changes

Wodann force-pushed the master branch from 1deae80 to 78b769e Compare November 4, 2019 22:27

Wodann requested a review from baszalmstra November 4, 2019 22:28

baszalmstra suggested changes Nov 5, 2019

View reviewed changes

include/mun/runtime.h Outdated Show resolved Hide resolved

Wodann and others added 3 commits November 5, 2019 15:57

feat: add C++ bindings for runtime and errors

8c92c02

doc(capi): add missing docs

fd88967

feat: add binaries

ccbc560

Wodann force-pushed the master branch from 78b769e to ccbc560 Compare November 5, 2019 14:58

Wodann requested a review from baszalmstra November 5, 2019 14:59

baszalmstra approved these changes Nov 5, 2019

View reviewed changes

Wodann merged commit 830bf08 into mun-lang:master Nov 5, 2019

Provide feedback