-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Input radius and skin thickness #31
Changes from 3 commits
aa1d2b4
98fffdd
49ecbeb
635d697
6263d40
a9e6515
15c89d8
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -83,7 +83,7 @@ double TransitionMatrix::totalRate() { | |||||
* @param dx: Logarithmic step of the grid (default = 0.005) | ||||||
* @retval | ||||||
*/ | ||||||
Atom::Atom(int Z, double m, int A, NuclearRadiusModel radius_model, double fc, | ||||||
Atom::Atom(int Z, double m, int A, double radius, NuclearRadiusModel radius_model, double fc, | ||||||
double dx) { | ||||||
// Set the properties | ||||||
this->Z = Z; | ||||||
|
@@ -112,24 +112,36 @@ Atom::Atom(int Z, double m, int A, NuclearRadiusModel radius_model, double fc, | |||||
// Define radius | ||||||
if (A == -1) { | ||||||
R = -1; | ||||||
} else { | ||||||
} else if (radius < 0) { | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @MichaelHeines , could you please explain this check? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is something Frederik put in and I slightly tweaked. If I'm not mistaken, this check tells you whether or not an input radius is given. If it isn't given, radius = -1, which defaults to the standard methods from mudirac. I suppose one could also rewrite this as else if (radius == -1) There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Then it would be good to write it as radius == -1, less confusing.
Suggested change
|
||||||
switch (radius_model) { | ||||||
case POINT: | ||||||
R = -1; | ||||||
break; | ||||||
case SPHERE: | ||||||
R = sphereNuclearModel(Z, A); | ||||||
LOG(INFO) << "SPHERE: R extracted as " << R << "\n"; | ||||||
break; | ||||||
case FERMI2: | ||||||
R = sphereNuclearModel(Z, A); | ||||||
LOG(INFO) << "FERMI2: R extracted as " << R << "\n"; | ||||||
break; | ||||||
default: | ||||||
R = -1; | ||||||
break; | ||||||
} | ||||||
} else { | ||||||
R = radius * Physical::fm; | ||||||
} | ||||||
|
||||||
if (radius_model==POINT) { | ||||||
R = -1; | ||||||
} else { | ||||||
LOG(INFO) << "R = " << radius << " fm\n"; | ||||||
} | ||||||
|
||||||
if (radius_model == FERMI2) { | ||||||
V_coulomb = new CoulombFermi2Potential(Z, R, A); | ||||||
} else { | ||||||
} else if (radius_model == SPHERE) { | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Currrenlty if the radiusl_model == 'POINT' case is ignored, It would be cause error if the keyword
Suggested change
|
||||||
V_coulomb = new CoulombSpherePotential(Z, R); | ||||||
} | ||||||
|
||||||
|
@@ -325,9 +337,9 @@ double Atom::sphereNuclearModel(int Z, int A) { | |||||
* (default = -1) | ||||||
* @retval | ||||||
*/ | ||||||
DiracAtom::DiracAtom(int Z, double m, int A, NuclearRadiusModel radius_model, | ||||||
DiracAtom::DiracAtom(int Z, double m, int A, double R, NuclearRadiusModel radius_model, | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. missing comments for the documentation |
||||||
double fc, double dx, int ideal_minshell) | ||||||
: Atom(Z, m, A, radius_model, fc, dx) { | ||||||
: Atom(Z, m, A, R, radius_model, fc, dx) { | ||||||
restE = mu * pow(Physical::c, 2); | ||||||
LOG(DEBUG) << "Rest energy = " << restE / Physical::eV << " eV\n"; | ||||||
idshell = ideal_minshell; | ||||||
|
@@ -1035,7 +1047,7 @@ TransitionMatrix DiracAtom::getTransitionProbabilities(int n1, int l1, bool s1, | |||||
return tmat; | ||||||
} | ||||||
|
||||||
DiracIdealAtom::DiracIdealAtom(int Z, double m, int A, | ||||||
DiracIdealAtom::DiracIdealAtom(int Z, double m, int A, double R, | ||||||
NuclearRadiusModel radius_model, double fc, | ||||||
double dx) | ||||||
: DiracAtom(Z, m, A, radius_model, fc, dx, 1) {} | ||||||
: DiracAtom(Z, m, A, R, radius_model, fc, dx, 1) {} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
documentation comment
@param radius:
missing for the new parameterreference