[Multisig] Sanity check new threshold/key pair during key updates #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current key update function allows following bad values. 1. Zero threshold value, when renders multisig contract without any additional security. 2. Threshold value that is larger than the number of keys, which locks out the multisig contract completely and renders it useless. This change adds sanity checks that rejects bad threshold/key pairs as listed above.
sras
force-pushed
the
sras/sanity-check-key-update
branch
from
8402d1a to
44f900c
Compare
|
IMO these checks should be done off-chain. The Tezos client already check this: https://gitlab.com/tezos/tezos/-/blob/master/src/proto_006_PsCARTHA/lib_client/client_proto_multisig.ml#L691. |
@rafoo Why though? Couldn't one can interact with a smart contract via |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sanity check new threshold/key pair during key updates
The current key update function allows following bad values for new threshold/key pair.
Threshold value is Zero, which renders multisig contract without any
additional security.
Threshold value is larger than the number of keys, which locks
out the multisig contract completely and renders it useless. This could even lock the target contract where the multisig contract acts as an administrator/owner.
This change adds sanity checks that rejects bad threshold/key pairs as
listed above.